Skip to content

Make logLevel property internal to not take it into account when caching #6399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

lwasyl
Copy link
Contributor

@lwasyl lwasyl commented Feb 27, 2025

Fixes #6398

@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Feb 27, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: ac40bc96dcd4efdc869bf7d0

Copy link
Contributor

@martinbonnin martinbonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinbonnin martinbonnin merged commit c786b5a into apollographql:main Feb 28, 2025
5 checks passed
@lwasyl lwasyl deleted the log-level-caching-6398 branch March 1, 2025 08:58
@martinbonnin martinbonnin added this to the 4.2.0 milestone Mar 20, 2025
@scana
Copy link

scana commented Apr 28, 2025

Hey @martinbonnin is there any chance this could get released as a patch for 4.1.1 instead of in 4.2.0?

Was talking to @erichaagdev from Gradle and we've thought of asking for it while investigating some build caching issues.

@martinbonnin
Copy link
Contributor

Hi @scana 👋 Is the concern of a timing concern? 4.2.0 is to be released in a matter of minutes. Would that work for you?

@scana
Copy link

scana commented Apr 28, 2025

Oh wow - that totally works! Thank you @martinbonnin!

@martinbonnin
Copy link
Contributor

All the credit goes to @BoD who just fired up the release. It's online now: https://repo1.maven.org/maven2/com/apollographql/apollo/apollo-api/4.2.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ApolloTaskWithClasspath is not cacheable if different Gradle log level options are used
4 participants