Skip to content

Close ApolloInterceptor if they implement Closeable #6281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Close ApolloInterceptor if they implement Closeable #6281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions libraries/apollo-runtime/src/commonMain/kotlin/com/apollographql/apollo/ApolloClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,11 @@ private constructor(
concurrencyInfo.coroutineScope.cancel()
networkTransport.dispose()
subscriptionNetworkTransport.dispose()
for (interceptor in interceptors) {
if (interceptor is Closeable) {
interceptor.close()
}
}
}

private val networkInterceptor = NetworkInterceptor(
Expand Down
6 changes: 5 additions & 1 deletion ...o-runtime/src/commonMain/kotlin/com/apollographql/apollo/interceptor/ApolloInterceptor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,18 @@
package com.apollographql.apollo.interceptor

import com.apollographql.apollo.api.ApolloRequest
import com.apollographql.apollo.api.Operation
import com.apollographql.apollo.api.ApolloResponse
import com.apollographql.apollo.api.Operation
import kotlinx.coroutines.flow.Flow

interface ApolloInterceptorChain {
fun <D : Operation.Data> proceed(request: ApolloRequest<D>): Flow<ApolloResponse<D>>
}

/**
* Implementations can optionally implement [okio.Closeable], if they do, their [okio.Closeable.close] function will be called when the
* [com.apollographql.apollo.ApolloClient] they are associated to is closed.
*/
interface ApolloInterceptor {
fun <D : Operation.Data> intercept(request: ApolloRequest<D>, chain: ApolloInterceptorChain): Flow<ApolloResponse<D>>
}
Expand Down
Loading