-
Notifications
You must be signed in to change notification settings - Fork 4
Design doc: add Declarative API section #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
76825c0
Add Declarative API section
BoD 800b58d
Dig more about reusing Apollo Server's @cacheControl directive
BoD 2a75ca6
Fix typo
BoD d97f091
Re-use the backend @cacheControl directive
BoD fb4b98e
Update programmatic API to make it closer and compatible with the @Ca…
BoD bea2437
Update Expiration.md
BoD 681299c
Add a note about codegen
BoD File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How much could we reuse the server side
@cacheControl
?https://www.apollographql.com/docs/apollo-server/performance/caching/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good callout! We could probably reuse it with a few remarks:
scope
is irrelevant on the client (can simply be ignored)inheritMaxAge
- not sure why it's usefulUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could have cross-user cache. For an example, in Confetti, all the session data is
PUBLIC
, but the bookmarks arePRIVATE
. We're not there yet but could be something?Agree ignoring it for now is fine.
Yea, either
@cacheControlField()
or field definition extensions in the GraphQL 2.0 spec 🤓Overall, agree that we could model things more precisely but the prospect of getting all of these for free from the backend is pretty enticing