Skip to content

Add removeOperation and removeFragment #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

Add removeOperation and removeFragment #135

merged 1 commit into from
Apr 28, 2025

Conversation

BoD
Copy link
Collaborator

@BoD BoD commented Apr 24, 2025

Implements #77

@BoD BoD requested a review from martinbonnin as a code owner April 24, 2025 18:37
@martinbonnin
Copy link
Contributor

We just discussed this. Putting this here for the record, have an API that takes the data to be removed would make it explicit that we first need to read the data. It's more composable and more explicit that a read is happening

@BoD BoD force-pushed the remove-operation branch from ac4f3d3 to 0551ca7 Compare April 25, 2025 15:59
Base automatically changed from tweak-simple-apollo-store to main April 28, 2025 13:27
@BoD BoD force-pushed the remove-operation branch from 0551ca7 to 3812706 Compare April 28, 2025 13:30
@BoD BoD merged commit 33eba59 into main Apr 28, 2025
2 checks passed
@BoD BoD deleted the remove-operation branch April 28, 2025 13:58
@BoD BoD mentioned this pull request Apr 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinbonnin martinbonnin Awaiting requested review from martinbonnin martinbonnin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BoD @martinbonnin