Db format changes and use CacheKey in more places

CHANGELOG.md

@@ -1,6 +1,10 @@
 # Next version (unreleased)
 
-PUT_CHANGELOG_HERE
+- Storage binary format is changed to be a bit more compact
+- Add `ApolloStore.trim()` to remove old data from the cache
+- `CacheKey` is used in more APIs instead of `String`, for consistency.
+- `ApolloCacheHeaders.EVICT_AFTER_READ` is removed. `ApolloStore.remove()` can be used instead.
+- `NormalizedCache.remove(pattern: String)` is removed. Please open an issues if you need this feature back.
 
 # Version 0.0.7
 _2025-03-03_

normalized-cache-incubating/src/commonMain/kotlin/com/apollographql/cache/normalized/ApolloStore.kt

@@ -26,6 +26,7 @@ import com.apollographql.cache.normalized.api.NormalizedCache
 import com.apollographql.cache.normalized.api.NormalizedCacheFactory
 import com.apollographql.cache.normalized.api.Record
 import com.apollographql.cache.normalized.api.RecordMerger
+import com.apollographql.cache.normalized.api.RecordValue
 import com.apollographql.cache.normalized.api.TypePolicyCacheKeyGenerator
 import com.apollographql.cache.normalized.internal.DefaultApolloStore
 import com.benasher44.uuid.Uuid
@@ -238,15 +239,27 @@ interface ApolloStore {
    */
   fun remove(cacheKeys: List<CacheKey>, cascade: Boolean = true): Int
 
+  /**
+   * Trims the store if its size exceeds [maxSizeBytes]. The amount of data to remove is determined by [trimFactor].
+   * The oldest records are removed according to their update date.
+   *
+   * This may not be supported by all cache implementations (currently this is implemented by the SQL cache).
+   *
+   * @param maxSizeBytes the size of the cache in bytes above which the cache should be trimmed.
+   * @param trimFactor the factor of the cache size to trim.
+   * @return the cache size in bytes after trimming or -1 if the operation is not supported.
+   */
+  fun trim(maxSizeBytes: Long, trimFactor: Float = 0.1f): Long
+
   /**
    * Normalizes executable data to a map of [Record] keyed by [Record.key].
    */
   fun <D : Executable.Data> normalize(
       executable: Executable<D>,
       dataWithErrors: DataWithErrors,
-      rootKey: String = CacheKey.rootKey().key,
+      rootKey: CacheKey = CacheKey.rootKey(),
       customScalarAdapters: CustomScalarAdapters = CustomScalarAdapters.Empty,
-  ): Map<String, Record>
+  ): Map<CacheKey, Record>
 
   /**
    * Publishes a set of keys that have changed. This will notify subscribers of [changedKeys].
@@ -273,7 +286,7 @@ interface ApolloStore {
    *
    * This is a synchronous operation that might block if the underlying cache is doing IO.
    */
-  fun dump(): Map<KClass<*>, Map<String, Record>>
+  fun dump(): Map<KClass<*>, Map<CacheKey, Record>>
 
   /**
    * Releases resources associated with this store.
@@ -312,16 +325,18 @@ internal interface ApolloStoreInterceptor : ApolloInterceptor
 internal fun ApolloStore.cacheDumpProvider(): () -> Map<String, Map<String, Pair<Int, Map<String, Any?>>>> {
   return {
     dump().map { (cacheClass, cacheRecords) ->
-      cacheClass.normalizedCacheName() to cacheRecords.mapValues { (_, record) ->
-        record.size to record.fields.mapValues { (_, value) ->
-          value.toExternal()
-        }
-      }
+      cacheClass.normalizedCacheName() to cacheRecords
+          .mapKeys { (key, _) -> key.keyToString() }
+          .mapValues { (_, record) ->
+            record.size to record.fields.mapValues { (_, value) ->
+              value.toExternal()
+            }
+          }
     }.toMap()
   }
 }
 
-private fun Any?.toExternal(): Any? {
+private fun RecordValue.toExternal(): Any? {
   return when (this) {
     null -> null
     is String -> this
@@ -331,6 +346,7 @@ private fun Any?.toExternal(): Any? {
     is Double -> this
     is JsonNumber -> this
     is CacheKey -> this.serialize()
+    is Error -> this
     is List<*> -> {
       map { it.toExternal() }
     }

normalized-cache-incubating/src/commonMain/kotlin/com/apollographql/cache/normalized/GarbageCollection.kt

@@ -11,16 +11,17 @@ import com.apollographql.cache.normalized.api.NormalizedCache
 import com.apollographql.cache.normalized.api.Record
 import com.apollographql.cache.normalized.api.RecordValue
 import com.apollographql.cache.normalized.api.expirationDate
+import com.apollographql.cache.normalized.api.fieldKey
 import com.apollographql.cache.normalized.api.receivedDate
 import kotlin.time.Duration
 
 @ApolloInternal
-fun Map<String, Record>.getReachableCacheKeys(): Set<CacheKey> {
-  fun Map<String, Record>.getReachableCacheKeys(roots: List<CacheKey>, reachableCacheKeys: MutableSet<CacheKey>) {
-    val records = roots.mapNotNull { this[it.key] }
+fun Map<CacheKey, Record>.getReachableCacheKeys(): Set<CacheKey> {
+  fun Map<CacheKey, Record>.getReachableCacheKeys(roots: List<CacheKey>, reachableCacheKeys: MutableSet<CacheKey>) {
+    val records = roots.mapNotNull { this[it] }
     val cacheKeysToCheck = mutableListOf<CacheKey>()
     for (record in records) {
-      reachableCacheKeys.add(CacheKey(record.key))
+      reachableCacheKeys.add(record.key)
       cacheKeysToCheck.addAll(record.referencedFields() - reachableCacheKeys)
     }
     if (cacheKeysToCheck.isNotEmpty()) {
@@ -34,7 +35,7 @@ fun Map<String, Record>.getReachableCacheKeys(): Set<CacheKey> {
 }
 
 @ApolloInternal
-fun NormalizedCache.allRecords(): Map<String, Record> {
+fun NormalizedCache.allRecords(): Map<CacheKey, Record> {
   return dump().values.fold(emptyMap()) { acc, map -> acc + map }
 }
 
@@ -49,8 +50,8 @@ fun NormalizedCache.removeUnreachableRecords(): Set<CacheKey> {
   return removeUnreachableRecords(allRecords)
 }
 
-private fun NormalizedCache.removeUnreachableRecords(allRecords: Map<String, Record>): Set<CacheKey> {
-  val unreachableCacheKeys = allRecords.keys.map { CacheKey(it) } - allRecords.getReachableCacheKeys()
+private fun NormalizedCache.removeUnreachableRecords(allRecords: Map<CacheKey, Record>): Set<CacheKey> {
+  val unreachableCacheKeys = allRecords.keys - allRecords.getReachableCacheKeys()
   remove(unreachableCacheKeys, cascade = false)
   return unreachableCacheKeys.toSet()
 }
@@ -89,11 +90,11 @@ fun NormalizedCache.removeStaleFields(
 }
 
 private fun NormalizedCache.removeStaleFields(
-    allRecords: MutableMap<String, Record>,
+    allRecords: MutableMap<CacheKey, Record>,
     maxAgeProvider: MaxAgeProvider,
     maxStale: Duration,
 ): RemovedFieldsAndRecords {
-  val recordsToUpdate = mutableMapOf<String, Record>()
+  val recordsToUpdate = mutableMapOf<CacheKey, Record>()
   val removedFields = mutableSetOf<String>()
   for (record in allRecords.values.toList()) {
     var recordCopy = record
@@ -115,7 +116,7 @@ private fun NormalizedCache.removeStaleFields(
         if (staleDuration >= maxStale.inWholeSeconds) {
           recordCopy -= field.key
           recordsToUpdate[record.key] = recordCopy
-          removedFields.add(record.key + "." + field.key)
+          removedFields.add(record.key.fieldKey((field.key)))
           if (recordCopy.isEmptyRecord()) {
             allRecords.remove(record.key)
           } else {
@@ -133,7 +134,7 @@ private fun NormalizedCache.removeStaleFields(
         if (staleDuration >= maxStale.inWholeSeconds) {
           recordCopy -= field.key
           recordsToUpdate[record.key] = recordCopy
-          removedFields.add(record.key + "." + field.key)
+          removedFields.add(record.key.fieldKey(field.key))
           if (recordCopy.isEmptyRecord()) {
             allRecords.remove(record.key)
           } else {
@@ -144,15 +145,15 @@ private fun NormalizedCache.removeStaleFields(
     }
   }
   if (recordsToUpdate.isNotEmpty()) {
-    remove(recordsToUpdate.keys.map { CacheKey(it) }, cascade = false)
+    remove(recordsToUpdate.keys, cascade = false)
     val emptyRecords = recordsToUpdate.values.filter { it.isEmptyRecord() }.toSet()
     val nonEmptyRecords = recordsToUpdate.values - emptyRecords
     if (nonEmptyRecords.isNotEmpty()) {
       merge(nonEmptyRecords, CacheHeaders.NONE, DefaultRecordMerger)
     }
     return RemovedFieldsAndRecords(
         removedFields = removedFields,
-        removedRecords = emptyRecords.map { CacheKey(it.key) }.toSet()
+        removedRecords = emptyRecords.map { it.key }.toSet()
     )
   }
   return RemovedFieldsAndRecords(removedFields = emptySet(), removedRecords = emptySet())
@@ -182,12 +183,12 @@ fun ApolloStore.removeStaleFields(
  * @return the fields and records that were removed.
  */
 fun NormalizedCache.removeDanglingReferences(): RemovedFieldsAndRecords {
-  val allRecords: MutableMap<String, Record> = allRecords().toMutableMap()
+  val allRecords: MutableMap<CacheKey, Record> = allRecords().toMutableMap()
   return removeDanglingReferences(allRecords)
 }
 
-private fun NormalizedCache.removeDanglingReferences(allRecords: MutableMap<String, Record>): RemovedFieldsAndRecords {
-  val recordsToUpdate = mutableMapOf<String, Record>()
+private fun NormalizedCache.removeDanglingReferences(allRecords: MutableMap<CacheKey, Record>): RemovedFieldsAndRecords {
+  val recordsToUpdate = mutableMapOf<CacheKey, Record>()
   val allRemovedFields = mutableSetOf<String>()
   do {
     val removedFields = mutableSetOf<String>()
@@ -197,7 +198,7 @@ private fun NormalizedCache.removeDanglingReferences(allRecords: MutableMap<Stri
         if (field.value.isDanglingReference(allRecords)) {
           recordCopy -= field.key
           recordsToUpdate[record.key] = recordCopy
-          removedFields.add(record.key + "." + field.key)
+          removedFields.add(record.key.fieldKey(field.key))
           if (recordCopy.isEmptyRecord()) {
             allRecords.remove(record.key)
           } else {
@@ -209,15 +210,15 @@ private fun NormalizedCache.removeDanglingReferences(allRecords: MutableMap<Stri
     allRemovedFields.addAll(removedFields)
   } while (removedFields.isNotEmpty())
   if (recordsToUpdate.isNotEmpty()) {
-    remove(recordsToUpdate.keys.map { CacheKey(it) }, cascade = false)
+    remove(recordsToUpdate.keys, cascade = false)
     val emptyRecords = recordsToUpdate.values.filter { it.isEmptyRecord() }.toSet()
     val nonEmptyRecords = recordsToUpdate.values - emptyRecords
     if (nonEmptyRecords.isNotEmpty()) {
       merge(nonEmptyRecords, CacheHeaders.NONE, DefaultRecordMerger)
     }
     return RemovedFieldsAndRecords(
         removedFields = allRemovedFields,
-        removedRecords = emptyRecords.map { CacheKey(it.key) }.toSet()
+        removedRecords = emptyRecords.map { it.key }.toSet()
     )
   }
   return RemovedFieldsAndRecords(removedFields = emptySet(), removedRecords = emptySet())
@@ -233,9 +234,9 @@ fun ApolloStore.removeDanglingReferences(): RemovedFieldsAndRecords {
   }
 }
 
-private fun RecordValue.isDanglingReference(allRecords: Map<String, Record>): Boolean {
+private fun RecordValue.isDanglingReference(allRecords: Map<CacheKey, Record>): Boolean {
   return when (this) {
-    is CacheKey -> allRecords[this.key] == null
+    is CacheKey -> allRecords[this] == null
     is List<*> -> any { it.isDanglingReference(allRecords) }
     is Map<*, *> -> values.any { it.isDanglingReference(allRecords) }
     else -> false
@@ -244,15 +245,15 @@ private fun RecordValue.isDanglingReference(allRecords: Map<String, Record>): Bo
 
 private fun Record.isEmptyRecord() = fields.isEmpty() || fields.size == 1 && fields.keys.first() == "__typename"
 
-private fun RecordValue.guessType(allRecords: Map<String, Record>): String {
+private fun RecordValue.guessType(allRecords: Map<CacheKey, Record>): String {
   return when (this) {
     is List<*> -> {
       val first = firstOrNull() ?: return ""
       first.guessType(allRecords)
     }
 
     is CacheKey -> {
-      allRecords[key]?.get("__typename") as? String ?: ""
+      allRecords[this]?.get("__typename") as? String ?: ""
     }
 
     else -> {

normalized-cache-incubating/src/commonMain/kotlin/com/apollographql/cache/normalized/api/ApolloCacheHeaders.kt

@@ -14,9 +14,7 @@ object ApolloCacheHeaders {
    */
   const val MEMORY_CACHE_ONLY = "memory-cache-only"
 
-  /**
-   * Records from this request should be evicted after being read.
-   */
+  @Deprecated(level = DeprecationLevel.ERROR, message = "This header has no effect and will be removed in a future release. Use ApolloStore.remove() instead.")
   const val EVICT_AFTER_READ = "evict-after-read"
 
   /**

normalized-cache-incubating/src/commonMain/kotlin/com/apollographql/cache/normalized/api/CacheKey.kt

@@ -1,14 +1,19 @@
 package com.apollographql.cache.normalized.api
 
+import com.apollographql.apollo.annotations.ApolloInternal
+import kotlin.jvm.JvmInline
 import kotlin.jvm.JvmStatic
 
 /**
  * A [CacheKey] identifies an object in the cache.
- *
- * @param key The key of the object in the cache. The key must be globally unique.
  */
-class CacheKey(val key: String) {
-
+@JvmInline
+value class CacheKey(
+    /**
+     * The key of the object in the cache.
+     */
+    val key: String,
+) {
   /**
    * Builds a [CacheKey] from a typename and a list of Strings.
    *
@@ -31,15 +36,14 @@ class CacheKey(val key: String) {
    */
   constructor(typename: String, vararg values: String) : this(typename, values.toList())
 
-  override fun hashCode() = key.hashCode()
-  override fun equals(other: Any?): Boolean {
-    return key == (other as? CacheKey)?.key
+  fun keyToString(): String {
+    return key
   }
 
-  override fun toString() = "CacheKey($key)"
+  override fun toString() = "CacheKey(${keyToString()})"
 
   fun serialize(): String {
-    return "$SERIALIZATION_TEMPLATE{$key}"
+    return "$SERIALIZATION_TEMPLATE{${keyToString()}}"
   }
 
   companion object {
@@ -71,3 +75,21 @@ class CacheKey(val key: String) {
     }
   }
 }
+
+fun CacheKey.isRootKey(): Boolean {
+  return this == CacheKey.rootKey()
+}
+
+@ApolloInternal
+fun CacheKey.fieldKey(fieldName: String): String {
+  return "${keyToString()}.$fieldName"
+}
+
+@ApolloInternal
+fun CacheKey.append(vararg keys: String): CacheKey {
+  var cacheKey: CacheKey = this
+  for (key in keys) {
+    cacheKey = CacheKey("${cacheKey.key}.$key")
+  }
+  return cacheKey
+}

normalized-cache-incubating/src/commonMain/kotlin/com/apollographql/cache/normalized/api/CacheResolver.kt

@@ -100,7 +100,7 @@ class ResolverContext(
     /**
      * The key of the parent. Mainly used for debugging
      */
-    val parentKey: String,
+    val parentKey: CacheKey,
 
     /**
      * The type of the parent
@@ -135,7 +135,7 @@ object DefaultCacheResolver : CacheResolver {
   override fun resolveField(context: ResolverContext): Any? {
     val fieldKey = context.getFieldKey()
     if (!context.parent.containsKey(fieldKey)) {
-      throw CacheMissException(context.parentKey, fieldKey)
+      throw CacheMissException(context.parentKey.keyToString(), fieldKey)
     }
 
     return context.parent[fieldKey]
@@ -190,7 +190,7 @@ class CacheControlCacheResolver(
         val maxStale = context.cacheHeaders.headerValue(ApolloCacheHeaders.MAX_STALE)?.toLongOrNull() ?: 0L
         if (staleDuration >= maxStale) {
           throw CacheMissException(
-              key = context.parentKey,
+              key = context.parentKey.keyToString(),
               fieldName = context.getFieldKey(),
               stale = true
           )
@@ -206,7 +206,7 @@ class CacheControlCacheResolver(
         val maxStale = context.cacheHeaders.headerValue(ApolloCacheHeaders.MAX_STALE)?.toLongOrNull() ?: 0L
         if (staleDuration >= maxStale) {
           throw CacheMissException(
-              key = context.parentKey,
+              key = context.parentKey.keyToString(),
               fieldName = context.getFieldKey(),
               stale = true
           )

normalized-cache-incubating/src/commonMain/kotlin/com/apollographql/cache/normalized/api/DataWithErrors.kt

@@ -186,3 +186,18 @@ private fun CompiledSelection.fieldSelection(responseName: String): CompiledFiel
         .build()
   }
 }
+
+@Suppress("UNCHECKED_CAST")
+internal fun Any?.hasErrors(): Boolean {
+  val queue = ArrayDeque<Any?>()
+  queue.add(this)
+  while (queue.isNotEmpty()) {
+    val current = queue.removeFirst()
+    when (current) {
+      is Error -> return true
+      is Map<*, *> -> queue.addAll(current.values)
+      is List<*> -> queue.addAll(current)
+    }
+  }
+  return false
+}