Don't call MetadataGenerator on error fields #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinbonnin
approved these changes
Mar 14, 2025
BoD
added a commit
that referenced
this pull request
Mar 28, 2025
* Hashed CacheKeys (WIP) * Use CacheKey in more places * Avoid using .hashed() * New 'fields' db format. Also, remove EVICT_AFTER_READ. * Add support for trim * Rename 'key' -> 'record' * Minor ApolloJsonElementSerializer optimizations * Do not call propagateErrors if there are no errors * Minor optimization in toRecords() * Use ByteString in CacheKey and blob in SQL. * Revert 1 field per row, and hashes * Renames for consistency * Add ApolloStore.trim() * Increase SQLite's memory cache to 8 MiB * Report #107 * Revert removal of assertChainedCachesAreEqual * Fix cacheDumpProvider to include errors * Minor tweak/rename * Remove debug * Revert removed test * Revert tweaked values * Update CHANGELOG.md * Encode certain known metadata keys as single byte strings to save space * Make CacheKey extensions internal, and add test-utils * Make CacheKey.keyToString() internal * Add a comment about using string lengths * Remove CacheKey.serialize() and co. * Optim: avoid some iterations while avoiding some iterations * RecordSerializer: encode ints smaller than 255-32 as one byte
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #106.