Skip to content

fix: remove the TypeScript course #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025

Conversation

honzajavorek
Copy link
Collaborator

The TypeScript course is an offtopic in the context of the Academy. It is not a web scraping course, and it is not related to the Apify platform per se. I see no reason why Apify should be teaching TypeScript. And I think the team has already enough other, more relevant docs to maintain.

When I joined, I wrote down an internal document called Apify Academy white paper, where I suggested deleting this content. I think it's more or less 1 year since I joined Apify, and I decided: Today is the day! Today I'm bold enough to actually propose the change in a PR. If this gets merged, I'll consider it as a gift to my work anniversary 😆

In the document, @mnmkng wrote the following:

I think it was created mostly to help users make the switch to TypeScript with Crawlee when we released full TS support. I don't even remember what's in there frankly and I'm pretty sure we can live without it.

Miley Cyrus

@honzajavorek honzajavorek added the t-academy Issues related to Web Scraping and Apify academies. label Apr 28, 2025
Copy link
Contributor

@TC-MO TC-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my POV more than fine, it always felt out of place within Academy

@mnmkng
Copy link
Member

mnmkng commented Apr 28, 2025

I'm wondering if perhaps @metalwarrior665 uses it to onboard new devs. If he does, I'd propose merging it into one long post and dropping it into tutorials, or moving it to Notion at least. If he doesn't, let's delete it.

@honzajavorek
Copy link
Collaborator Author

OK, I'll wait for @metalwarrior665's input.

@honzajavorek honzajavorek force-pushed the honzajavorek/remove-typescript-course branch from 5e7e797 to 43eea39 Compare April 29, 2025 07:44
Copy link
Member

@metalwarrior665 metalwarrior665 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tell new devs to go through whole Academy but I'm with you that this course should not be there. I have always been of the opinion that the Academy should only contain articles related to scraping or Apify and only (or with massive preference) show the latest best practices. So I was even opposing the generic Puppeteer & Playwright course :)

@honzajavorek
Copy link
Collaborator Author

Do you think it's worth to redirect the URLs somewhere or should I just let them 404?

@mnmkng
Copy link
Member

mnmkng commented May 2, 2025

Do you think it's worth to redirect the URLs somewhere or should I just let them 404?

404s suck for SEO, so maybe let's create a single page document in tutorials with a similar title, redirect there, and explain that we recommend a list of good external typescript courses?

@metalwarrior665
Copy link
Member

For lazy solution, it could redirect to https://apify.com/templates/categories/typescript even though it is not all related to scraping

@honzajavorek
Copy link
Collaborator Author

I like the lazy solution 😅

@TC-MO
Copy link
Contributor

TC-MO commented May 5, 2025

I would second the lazy solution

@honzajavorek
Copy link
Collaborator Author

It's enough to add a rewrite to nginx.conf, right? Does it auto-deploy after merge?

@TC-MO
Copy link
Contributor

TC-MO commented May 5, 2025

From what I remember it should work like that

The TypeScript course is an offtopic in the context of the Academy.
It is not a web scraping course, and it is not related to the Apify
platform per se. I see no reason why Apify should be teaching
TypeScript. I think we have enough more relevant docs to maintain.
@honzajavorek honzajavorek force-pushed the honzajavorek/remove-typescript-course branch from 43eea39 to 4e35a06 Compare May 6, 2025 16:07
@honzajavorek
Copy link
Collaborator Author

Hopefully I got the redirect right. Can someone please check? I asked ChatGPT and it told me it swears it's correct, but I'd appreciate human eyes as well 😅

@mnmkng
Copy link
Member

mnmkng commented May 7, 2025

Hopefully I got the redirect right. Can someone please check? I asked ChatGPT and it told me it swears it's correct, but I'd appreciate human eyes as well 😅

@B4nan 🙏

Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the redirect looks good

@honzajavorek
Copy link
Collaborator Author

Alright, let’s smash it down with the wrecking ball! 🥲

@honzajavorek honzajavorek merged commit 57d7c29 into master May 7, 2025
8 checks passed
@honzajavorek honzajavorek deleted the honzajavorek/remove-typescript-course branch May 7, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-academy Issues related to Web Scraping and Apify academies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants