Refactor JSON handling code towards assumeState
#3210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thpani
approved these changes
Nov 6, 2025
| test("validateShapeAndGetTypes") { | ||
|
|
||
| val empty = UJsonRep(Obj()) | ||
| assert { |
Member
There was a problem hiding this comment.
Can we replace those curly braces?
Collaborator
Author
There was a problem hiding this comment.
Yep, this looks confusing
Collaborator
Author
There was a problem hiding this comment.
Good that Claude can refactor this kind of code :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to implement
assumeStatein JSON-RPC. However, this required me to touch the ITF parser. Went down the rabbit hole of refactoring the existing code and moving things around. This is mostly the refactoring commit, including a few new classes in JSON-RPC. The next step is to adapt the ITF parser to deal with Jackson and expressions instead of exclusively traces.make fmt-fix(or had formatting run automatically on all files edited)