Skip to content

fix: Button margin and close button in data explorer #3883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2025
Merged

fix: Button margin and close button in data explorer #3883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions ...a-explorer-shared/components/chart-container/data-explorer-chart-container.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,18 +134,21 @@
</button>
</sp-time-selector-menu>
</mat-menu>
<button
mat-icon-button
(click)="removeWidget()"
[matTooltip]="'Delete Chart' | translate"
*ngIf="editMode && hasDataExplorerWritePrivileges"
[attr.data-cy]="
'remove-' +
configuredWidget.baseAppearanceConfig.widgetTitle
"
>
<mat-icon>clear</mat-icon>
</button>
@if (!dataViewMode) {
<button
mat-icon-button
(click)="removeWidget()"
[matTooltip]="'Delete Chart' | translate"
*ngIf="editMode && hasDataExplorerWritePrivileges"
[attr.data-cy]="
'remove-' +
configuredWidget.baseAppearanceConfig
.widgetTitle
"
>
<mat-icon>clear</mat-icon>
</button>
}
</div>
}
</div>
Expand Down
8 changes: 2 additions & 6 deletions ui/src/app/editor/dialog/save-pipeline/save-pipeline.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,18 +50,17 @@
</div>
</div>
<mat-divider></mat-divider>
<div class="sp-dialog-actions">
<div class="sp-dialog-actions" fxLayoutGap="10px">
<button
mat-flat-button
color="accent"
(click)="hide(false)"
*ngIf="operationCompleted"
>
Create another pipeline
</button>
<button
mat-flat-button
color="accent"
class="mat-basic"
data-cy="sp-navigate-to-pipeline-overview"
(click)="navigateToPipelineOverview()"
*ngIf="operationCompleted"
Expand All @@ -75,11 +74,9 @@
operationProgress ||
operationCompleted
"
mat-button
mat-flat-button
color="accent"
(click)="savePipeline()"
style="margin-right: 10px"
data-cy="sp-editor-apply"
>
Apply
Expand All @@ -88,7 +85,6 @@
*ngIf="
!operationProgress && (!operationCompleted || !operationSuccess)
"
mat-button
mat-flat-button
class="mat-basic"
(click)="hide(true)"
Expand Down
Loading