Skip to content

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Oct 16, 2025

What changes were proposed in this pull request?

Fix SBT assembly for all sub-projects to handle META-INF correctly

  • META-INF/*.SF (signature files, should be dropped for assembly jars)
  • META-INF/services/* (service loader implementation list, should be merged for assembly jars)

Similiar thing was already done in the assembly project.

spark/project/SparkBuild.scala

Lines 1300 to 1310 in 83be7e7

(assembly / assemblyMergeStrategy) := {
case m if m.toLowerCase(Locale.ROOT).endsWith("manifest.mf")
=> MergeStrategy.discard
case m if m.toLowerCase(Locale.ROOT).matches("meta-inf.*\\.sf$")
=> MergeStrategy.discard
case "log4j2.properties" => MergeStrategy.discard
case m if m.toLowerCase(Locale.ROOT).startsWith("meta-inf/services/")
=> MergeStrategy.filterDistinctLines
case "reference.conf" => MergeStrategy.concat
case _ => MergeStrategy.first
}

Why are the changes needed?

Issue was detected when I'm trying to integrate Connect JDBC driver with BeeLine in dev mode.

Does this PR introduce any user-facing change?

No, official release uses Maven, which does not get affected.

How was this patch tested?

Pass GHA.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the BUILD label Oct 16, 2025
@pan3793
Copy link
Member Author

pan3793 commented Oct 16, 2025

cc @dongjoon-hyun @LuciferYang

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @pan3793 .

Copy link
Contributor

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@sarutak sarutak closed this in 24a6abf Oct 16, 2025
@sarutak
Copy link
Member

sarutak commented Oct 16, 2025

LGTM. Merged to master.
Thank you @pan3793 @dongjoon-hyun @LuciferYang !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants