Skip to content

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Oct 15, 2025

What changes were proposed in this pull request?

This PR aims to rename spark.executor.log.redirectConsoleOutputs to spark.executor.logs.redirectConsoleOutputs to be consistent with the existing executor log configurations like the following.

spark.executor.logs.rolling.strategy
spark.executor.logs.rolling.time.interval
spark.executor.logs.rolling.maxSize
spark.executor.logs.rolling.maxRetainedFiles
spark.executor.logs.rolling.enableCompression
spark.executor.logs.redirectConsoleOutputs

Why are the changes needed?

Although SPARK-52426 introduced two configurations consistently in the PR, Apache Spark has different namespaces for Driver and Executor which are spark.driver.log.* and spark.executor.logs.* respectively. Instead of introducing a new config namespace, spark.executor.log, for this single new configuration, we had better follow the existing naming rule.

spark.driver.log.redirectConsoleOutputs
spark.executor.log.redirectConsoleOutputs

Does this PR introduce any user-facing change?

No this is not released yet.

How was this patch tested?

Pass the CIs. Manual review.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the CORE label Oct 15, 2025
@dongjoon-hyun
Copy link
Member Author

cc @pan3793 , @yaooqinn , @peter-toth

@dongjoon-hyun
Copy link
Member Author

Thank you, @peter-toth .

Copy link
Member

@pan3793 pan3793 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I haven't noticed the existing spark.executor.logs config namespace, the change makes the config names more consistent.

@dongjoon-hyun
Copy link
Member Author

Thank you, @pan3793 .

@dongjoon-hyun
Copy link
Member Author

Merged to master for Apache Spark 4.1.0-preview3.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-53923 branch October 15, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants