[SPARK-53901][CONNECT] Handle potential memory leaks inSparkConnectAddArtifactsHandler upon flush/error
#52610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @hvanhovell |
vicennial
changed the title
stagedArtifacts buffer in SparkConnectAddArtifactsHandler upon flush/errorSparkConnectAddArtifactsHandler upon flush/error
hvanhovell
reviewed
Oct 14, 2025
...er/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectAddArtifactsHandler.scala
Outdated
Show resolved
Hide resolved
hvanhovell
reviewed
Oct 14, 2025
| // exception, we still attempt to close the inner streams to prevent resource leaks. | ||
| var closeException: Throwable = null | ||
| try { | ||
| checksumOut.close() |
There was a problem hiding this comment.
While I file it commendable that you are trying to close the inner input streams, I think this is slightly over engineered. If you look at the implementation of both CountingOutputStream and CountingOutputStream, then you'll see that close is guaranteed to be called on their inner stream. So we don't really have to go through this dance. Alternatively you close the fileOut directly.
There was a problem hiding this comment.
Good point, updated!
hvanhovell
reviewed
Oct 14, 2025
...er/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectAddArtifactsHandler.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Close the streams and clear the
stagedArtifactsbuffer when it is no longer needed. Further, we explicitly attempt to close inner streams in case closing an outer stream (which generally cascades down) fails.Why are the changes needed?
Upon flushing artifacts (or on an error), we delete the files on disk but the buffer is never cleared (and potentially open file handles), despite not being required anymore. An optimisation here is to clear them without relying on GC
Does this PR introduce any user-facing change?
No.
How was this patch tested?
New unit tests.
Was this patch authored or co-authored using generative AI tooling?
Co-authored with assistance from Claude Code.