[SPARK-53893][TESTS] Regenerate benchmark results after upgrading to Scala 2.13.17 #52600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
commented
Oct 14, 2025
| ----------------------------------------------------------------------------------------------------------------------------- | ||
| Compression 1024 array values in 1 threads 44 50 3 0.0 43112.9 1.0X | ||
| Compression 1024 array values single-threaded 32 33 0 0.0 31315.1 1.4X | ||
| Compression 1024 array values in 2 threads 23 25 1 0.0 22108.7 1.0X |
There was a problem hiding this comment.
The number of thread seems to be changed by GitHub Action side.
spark/core/src/test/scala/org/apache/spark/io/LZFBenchmark.scala
Lines 69 to 77 in 7d028c6
dongjoon-hyun
commented
Oct 14, 2025
| Decompression 10000 times from level 3 with buffer pool 540 541 0 0.0 54016.9 1.1X | ||
| Decompression 10000 times from level 1 without buffer pool 166 167 0 0.1 16645.6 1.0X | ||
| Decompression 10000 times from level 2 without buffer pool 166 166 0 0.1 16558.6 1.0X | ||
| Decompression 10000 times from level 3 without buffer pool 166 167 0 0.1 16629.4 1.0X |
There was a problem hiding this comment.
The ZSTD decompression speed is improved in Java 17 benchmark. Since Java 21 doesn't show any change, it could be some transient result.
LuciferYang
approved these changes
Oct 14, 2025
yaooqinn
approved these changes
Oct 14, 2025
dongjoon-hyun
commented
Oct 14, 2025
| UTF-32 56295 56403 153 0.2 5629.5 1.0X | ||
| UTF-16 50644 50653 13 0.2 5064.4 1.1X | ||
| UTF-8 30599 30619 28 0.3 3059.9 1.8X | ||
| UTF-32 33517 33545 41 0.3 3351.7 1.0X |
There was a problem hiding this comment.
Here, UTF-32 performance is improved, but Java 21 result is the same. This could be a transient one.
|
Thank you, @LuciferYang and @yaooqinn . |
|
At the first glance, there is no outstanding regression .Let me merge this since this is only a result of regeneration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to regenerate benchmark results after upgrading to Scala 2.13.17.
Why are the changes needed?
Since last update, we change important libraries, not only Scala, but also Hadoop, ORC, ZSTD libraries. This PR aims to make the benchmark result up-to-date as a way to detect any performance regression.
ZSTD-JNIto 1.5.7-5 #52591Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual review.
Was this patch authored or co-authored using generative AI tooling?
No.