[SPARK-53936][BUILD] Upgrade sbt-pom-reader from 2.4.0 to 2.5.0 #52580
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade the sbt-pom-reader SBT plugin to the latest to date release, made per request by Yuming Wang <yumwang@apache.org>. The request is centered on a switch to HTTPS only for accessing Maven Central, the release brings that fix. Besides that, the release brings upgrade for the Maven libraries (3.8.x to 3.9.x, resolver 1.7.x to 1.9.x).
|
@gemelen Could you enable the github action? https://github.com/apache/spark/pull/52580/checks?check_run_id=52567136730 |
|
@wangyum as far as I can tell, I enabled it. I could not find a way to rerun though. |
|
Run this step: |
|
Please also file a Jira ticket: https://issues.apache.org/jira/browse/SPARK |
There was a problem hiding this comment.
Pull Request Overview
Upgrade sbt-pom-reader plugin to incorporate latest release changes (including HTTPS-only access to Maven Central and Maven library upgrades).
- Bumps sbt-pom-reader from 2.4.0 to 2.5.0.
- No functional/user-facing code changes beyond build configuration.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
wangyum
changed the title
|
I have tested it myself, this upgrade is works. |
|
LGTM. Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
This PR updates the sbt-pom-reader plugin from version 2.4.0 to 2.5.0 in project/plugins.sbt.
What changes were proposed in this pull request?
The current build uses sbt-pom-reader 2.4.0, which hardcodes the Maven Central URL as http://repo.maven.apache.org/maven2. Our environment enforces HTTPS-only outbound connections, causing dependency resolution failures with that version.
Upstream PR(https://github.com/sbt/sbt-pom-reader/pull/81/files#diff-c2afee6a87a7bc518d0b31ecefaf824499b310218016b5865825dd6ef1eb216e) updates the plugin to use the secure https://repo.maven.apache.org/maven2 endpoint. This change is published in sbt-pom-reader 2.5.0.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing test suites.
Was this patch authored or co-authored using generative AI tooling?
No.