Skip to content

[SPARK-52147][SQL][TESTS] Block temporary object references in persistent SQL UDFs #51625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+283 −0
Closed

[SPARK-52147][SQL][TESTS] Block temporary object references in persistent SQL UDFs #51625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
120 changes: 120 additions & 0 deletions sql/core/src/test/resources/sql-tests/analyzer-results/sql-udf.sql.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3747,6 +3747,96 @@ RESET spark.sql.ansi.enabled
ResetCommand spark.sql.ansi.enabled


-- !query
CREATE TEMPORARY VIEW t AS VALUES (0) t(a)
-- !query analysis
CreateViewCommand `t`, VALUES (0) t(a), false, false, LocalTempView, UNSUPPORTED, true
+- SubqueryAlias t
+- LocalRelation [a#x]


-- !query
CREATE TEMPORARY FUNCTION foo3_5a(x INT) RETURNS INT RETURN x
-- !query analysis
CreateSQLFunctionCommand foo3_5a, x INT, INT, x, false, true, false, false


-- !query
CREATE TEMPORARY FUNCTION foo3_5b(x INT) RETURNS INT RETURN (SELECT SUM(a) FROM t)
-- !query analysis
CreateSQLFunctionCommand foo3_5b, x INT, INT, (SELECT SUM(a) FROM t), false, true, false, false


-- !query
CREATE TEMPORARY FUNCTION foo3_5c(x INT) RETURNS TABLE (a INT) RETURN SELECT a FROM t
-- !query analysis
CreateSQLFunctionCommand foo3_5c, x INT, a INT, SELECT a FROM t, true, true, false, false


-- !query
CREATE FUNCTION foo3_5d(x INT) RETURNS INT RETURN foo3_5a(x)
-- !query analysis
org.apache.spark.sql.AnalysisException
{
"errorClass" : "INVALID_TEMP_OBJ_REFERENCE",
"sqlState" : "42K0F",
"messageParameters" : {
"obj" : "FUNCTION",
"objName" : "`default`.`foo3_5d`",
"tempObj" : "FUNCTION",
"tempObjName" : "`foo3_5a`"
}
}


-- !query
CREATE FUNCTION foo3_5d(x INT) RETURNS TABLE (a INT) RETURN SELECT foo3_5a(x)
-- !query analysis
org.apache.spark.sql.AnalysisException
{
"errorClass" : "INVALID_TEMP_OBJ_REFERENCE",
"sqlState" : "42K0F",
"messageParameters" : {
"obj" : "FUNCTION",
"objName" : "`default`.`foo3_5d`",
"tempObj" : "FUNCTION",
"tempObjName" : "`foo3_5a`"
}
}


-- !query
CREATE FUNCTION foo3_5d(x INT) RETURNS INT RETURN (SELECT SUM(a) FROM t)
-- !query analysis
org.apache.spark.sql.AnalysisException
{
"errorClass" : "INVALID_TEMP_OBJ_REFERENCE",
"sqlState" : "42K0F",
"messageParameters" : {
"obj" : "FUNCTION",
"objName" : "`default`.`foo3_5d`",
"tempObj" : "VIEW",
"tempObjName" : "`t`"
}
}


-- !query
CREATE FUNCTION foo3_5d(x INT) RETURNS TABLE (a INT) RETURN SELECT a FROM t
-- !query analysis
org.apache.spark.sql.AnalysisException
{
"errorClass" : "INVALID_TEMP_OBJ_REFERENCE",
"sqlState" : "42K0F",
"messageParameters" : {
"obj" : "FUNCTION",
"objName" : "`default`.`foo3_5d`",
"tempObj" : "VIEW",
"tempObjName" : "`t`"
}
}


-- !query
CREATE FUNCTION foo3_14a() RETURNS INT RETURN 1
-- !query analysis
Expand Down Expand Up @@ -4828,3 +4918,33 @@ DropFunctionCommand spark_catalog.default.foo4_2, true, false
DROP FUNCTION IF EXISTS foo4_3
-- !query analysis
DropFunctionCommand spark_catalog.default.foo4_3, true, false


-- !query
DROP TEMPORARY FUNCTION IF EXISTS foo1d3
-- !query analysis
DropFunctionCommand foo1d3, true, true


-- !query
DROP TEMPORARY FUNCTION IF EXISTS foo3_3b
-- !query analysis
DropFunctionCommand foo3_3b, true, true


-- !query
DROP TEMPORARY FUNCTION IF EXISTS foo3_5a
-- !query analysis
DropFunctionCommand foo3_5a, true, true


-- !query
DROP TEMPORARY FUNCTION IF EXISTS foo3_5b
-- !query analysis
DropFunctionCommand foo3_5b, true, true


-- !query
DROP TEMPORARY FUNCTION IF EXISTS foo3_5c
-- !query analysis
DropFunctionCommand foo3_5c, true, true
19 changes: 19 additions & 0 deletions sql/core/src/test/resources/sql-tests/inputs/sql-udf.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -787,6 +787,18 @@ SELECT * FROM foo3_3ct();
SELECT * FROM foo3_3dt();
RESET spark.sql.ansi.enabled;

-- 3.5 Permanent functions with temp objects are not allowed
CREATE TEMPORARY VIEW t AS VALUES (0) t(a);
CREATE TEMPORARY FUNCTION foo3_5a(x INT) RETURNS INT RETURN x;
CREATE TEMPORARY FUNCTION foo3_5b(x INT) RETURNS INT RETURN (SELECT SUM(a) FROM t);
CREATE TEMPORARY FUNCTION foo3_5c(x INT) RETURNS TABLE (a INT) RETURN SELECT a FROM t;
-- Expect error: permanent function cannot reference temporary function
CREATE FUNCTION foo3_5d(x INT) RETURNS INT RETURN foo3_5a(x);
CREATE FUNCTION foo3_5d(x INT) RETURNS TABLE (a INT) RETURN SELECT foo3_5a(x);
-- Expect error: permanent function cannot reference temporary view
CREATE FUNCTION foo3_5d(x INT) RETURNS INT RETURN (SELECT SUM(a) FROM t);
CREATE FUNCTION foo3_5d(x INT) RETURNS TABLE (a INT) RETURN SELECT a FROM t;

-- 3.14 Invalid usage of SQL scalar/table functions in query clauses.
CREATE FUNCTION foo3_14a() RETURNS INT RETURN 1;
CREATE FUNCTION foo3_14b() RETURNS TABLE (a INT) RETURN SELECT 1;
Expand Down Expand Up @@ -948,3 +960,10 @@ DROP FUNCTION IF EXISTS foo4_0;
DROP FUNCTION IF EXISTS foo4_1;
DROP FUNCTION IF EXISTS foo4_2;
DROP FUNCTION IF EXISTS foo4_3;

-- Drop temporary functions
DROP TEMPORARY FUNCTION IF EXISTS foo1d3;
DROP TEMPORARY FUNCTION IF EXISTS foo3_3b;
DROP TEMPORARY FUNCTION IF EXISTS foo3_5a;
DROP TEMPORARY FUNCTION IF EXISTS foo3_5b;
DROP TEMPORARY FUNCTION IF EXISTS foo3_5c;
144 changes: 144 additions & 0 deletions sql/core/src/test/resources/sql-tests/results/sql-udf.sql.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3887,6 +3887,110 @@ struct<>



-- !query
CREATE TEMPORARY VIEW t AS VALUES (0) t(a)
-- !query schema
struct<>
-- !query output



-- !query
CREATE TEMPORARY FUNCTION foo3_5a(x INT) RETURNS INT RETURN x
-- !query schema
struct<>
-- !query output



-- !query
CREATE TEMPORARY FUNCTION foo3_5b(x INT) RETURNS INT RETURN (SELECT SUM(a) FROM t)
-- !query schema
struct<>
-- !query output



-- !query
CREATE TEMPORARY FUNCTION foo3_5c(x INT) RETURNS TABLE (a INT) RETURN SELECT a FROM t
-- !query schema
struct<>
-- !query output



-- !query
CREATE FUNCTION foo3_5d(x INT) RETURNS INT RETURN foo3_5a(x)
-- !query schema
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
{
"errorClass" : "INVALID_TEMP_OBJ_REFERENCE",
"sqlState" : "42K0F",
"messageParameters" : {
"obj" : "FUNCTION",
"objName" : "`default`.`foo3_5d`",
"tempObj" : "FUNCTION",
"tempObjName" : "`foo3_5a`"
}
}


-- !query
CREATE FUNCTION foo3_5d(x INT) RETURNS TABLE (a INT) RETURN SELECT foo3_5a(x)
-- !query schema
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
{
"errorClass" : "INVALID_TEMP_OBJ_REFERENCE",
"sqlState" : "42K0F",
"messageParameters" : {
"obj" : "FUNCTION",
"objName" : "`default`.`foo3_5d`",
"tempObj" : "FUNCTION",
"tempObjName" : "`foo3_5a`"
}
}


-- !query
CREATE FUNCTION foo3_5d(x INT) RETURNS INT RETURN (SELECT SUM(a) FROM t)
-- !query schema
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
{
"errorClass" : "INVALID_TEMP_OBJ_REFERENCE",
"sqlState" : "42K0F",
"messageParameters" : {
"obj" : "FUNCTION",
"objName" : "`default`.`foo3_5d`",
"tempObj" : "VIEW",
"tempObjName" : "`t`"
}
}


-- !query
CREATE FUNCTION foo3_5d(x INT) RETURNS TABLE (a INT) RETURN SELECT a FROM t
-- !query schema
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
{
"errorClass" : "INVALID_TEMP_OBJ_REFERENCE",
"sqlState" : "42K0F",
"messageParameters" : {
"obj" : "FUNCTION",
"objName" : "`default`.`foo3_5d`",
"tempObj" : "VIEW",
"tempObjName" : "`t`"
}
}


-- !query
CREATE FUNCTION foo3_14a() RETURNS INT RETURN 1
-- !query schema
Expand Down Expand Up @@ -5095,3 +5199,43 @@ DROP FUNCTION IF EXISTS foo4_3
struct<>
-- !query output



-- !query
DROP TEMPORARY FUNCTION IF EXISTS foo1d3
-- !query schema
struct<>
-- !query output



-- !query
DROP TEMPORARY FUNCTION IF EXISTS foo3_3b
-- !query schema
struct<>
-- !query output



-- !query
DROP TEMPORARY FUNCTION IF EXISTS foo3_5a
-- !query schema
struct<>
-- !query output



-- !query
DROP TEMPORARY FUNCTION IF EXISTS foo3_5b
-- !query schema
struct<>
-- !query output



-- !query
DROP TEMPORARY FUNCTION IF EXISTS foo3_5c
-- !query schema
struct<>
-- !query output