[SPARK-52925][SQL] Return correct error message for anchor self references in rCTEs #51619
+187
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
reviewed
Jul 22, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveWithCTE.scala
Outdated
Show resolved
Hide resolved
|
Let's file a JIRA |
Pajaraja
changed the title
Added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Catch case when there is a self reference in the anchor, and return an error message that this is an illegal rCTE.
Why are the changes needed?
Currently the cases where rCTEs are self referenced inside the anchor return unhelpful messages which happen due to the fact that the recursive CTE isn't defined at the time.
Does this PR introduce any user-facing change?
Different error messages.
How was this patch tested?
New golden file tests that check that cover cases with self references inside the anchor.
Was this patch authored or co-authored using generative AI tooling?
No.