[SPARK-51505][SQL] Always show empty partition number metrics in AQEShuffleReadExec #51608
+24
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
approved these changes
Jul 22, 2025
|
The test failure in |
the-sakthi
reviewed
Jul 23, 2025
| @@ -1092,7 +1092,7 @@ class AdaptiveQueryExecSuite | |||
| } | |||
| } | |||
|
|
|||
| test("metrics of the shuffle read") { | |||
| test("AABCmetrics of the shuffle read") { | |||
There was a problem hiding this comment.
"AABCmetrics" -- any specific meaning to this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
A followup for #50273 Always show empty partition number metrics in AQEShuffleReadExec
Why are the changes needed?
Even when there is no coaclescing, we still want to know empty partitions: imaging we have shuffle skewness and each non-empty partition is large so no coalescing happen, but there are many empty partitions.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Update UT
Was this patch authored or co-authored using generative AI tooling?
NO