Simplify build files for pipelines module #51089
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
reviewed
Jun 4, 2025
sql/pipelines/pom.xml
Outdated
| </dependencies> | ||
| <build> | ||
| <outputDirectory>target/scala-${scala.binary.version}/classes</outputDirectory> | ||
| <testOutputDirectory>target/scala-${scala.binary.version}/test-classes</testOutputDirectory> | ||
| <plugins> |
There was a problem hiding this comment.
In fact, this plugin is also redundant.
There was a problem hiding this comment.
Great to simplify – I just took this out.
project/SparkBuild.scala
Outdated
| @@ -884,6 +886,36 @@ object SparkConnectClient { | |||
| ) | |||
| } | |||
|
|
|||
| object SparkDeclarativePipelines { | |||
There was a problem hiding this comment.
So far, it seems that SparkDeclarativePipelines doesn't require any additional configuration. I changed it to
object SparkDeclarativePipelines {
lazy val settings = Seq()
}
and then executed build/sbt clean "pipelines/test". All the tests still passed.
There was a problem hiding this comment.
Great - I just took this out.
|
I ended up including this inside the underlying PR, so now closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup PR to #51003, which removes extraneous elements from the sbt and Maven build files, as suggested by @LuciferYang.
Why are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No