[SPARK-52312][SQL] Ignore V2WriteCommand when caching DataFrame #51032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
reviewed
May 28, 2025
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
May 28, 2025
sql/core/src/test/scala/org/apache/spark/sql/DataFrameWriterV2Suite.scala
Show resolved
Hide resolved
cloud-fan
reviewed
May 29, 2025
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala
Show resolved
Hide resolved
cloud-fan
approved these changes
May 29, 2025
cloud-fan
approved these changes
May 29, 2025
|
thanks, merging to master! |
yhuang-db
pushed a commit
to yhuang-db/spark
that referenced
this pull request
Jun 9, 2025
### What changes were proposed in this pull request? We found an issue that `V2WriteCommand` plans were not properly excluded from `DataFrame` caching, which can cause unintended side effects. For example, when `cache()` is called on a `DataFrame` created from an `INSERT` SQL statement, the `INSERT` command gets re-executed during the caching process because the underlying plan is not being ignored. This PR fixes this by - making `V2WriteCommand` extend the `IgnoreCachedData` trait - updating the caching logic to skip plans that extend `IgnoreCachedData`, preventing inapplicable plans from being cached ### Why are the changes needed? This is a bug, since calling `cache()` on a `DataFrame` shouldn't re-execute the command that created it. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? New tests were added. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#51032 from qiyuandong-db/SPARK-52312-ignore-v2writecommand-caching. Authored-by: Qiyuan Dong <qiyuan.dong@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We found an issue that
V2WriteCommandplans were not properly excluded fromDataFramecaching, which can cause unintended side effects.For example, when
cache()is called on aDataFramecreated from anINSERTSQL statement, theINSERTcommand gets re-executed during the caching process because the underlying plan is not being ignored.This PR fixes this by
V2WriteCommandextend theIgnoreCachedDatatraitIgnoreCachedData, preventing inapplicable plans from being cachedWhy are the changes needed?
This is a bug, since calling
cache()on aDataFrameshouldn't re-execute the command that created it.Does this PR introduce any user-facing change?
No.
How was this patch tested?
New tests were added.
Was this patch authored or co-authored using generative AI tooling?
No.