[SPARK-52311][SQL] Fix bug with multiple self-references with UnresolvedSubqueries in rCTEs #51022
+804
−737
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change the way the output is handled in the case where we give the names of the columns in the rCTE as a SubqueryAlias is handled. Now we make sure that anchor gives the correct names by pushing the UnresolvedSubqueryColumnAlias into it, and also make sure that the UnionLoopRef has this output as well.
Why are the changes needed?
Currently rCTEs don't behave properly in case when the anchor references the same column multiple times in the anchor, leading to wrong things being identified in the recursion.
For example this rCTE:
Will return:
Instead of:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
New tests in cte-recursion.sql golden file.
Was this patch authored or co-authored using generative AI tooling?
No.