[SPARK-51463] Add Spark Connect-generated Swift source code
#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
commented
Mar 11, 2025
| @@ -15,5 +15,6 @@ header: | |||
| - '.asf.yaml' | |||
| - '.nojekyll' | |||
| - 'Package.swift' | |||
| - '**/*pb.swift' | |||
There was a problem hiding this comment.
These generated files contains ASF license headers but starts with additional text patterns.
// DO NOT EDIT.
// swift-format-ignore-file
// swiftlint:disable all
...
|
Could you review this |
|
Thank you so much, @LuciferYang ! |
|
Merged to main. |
Closed
dongjoon-hyun
added a commit
that referenced
this pull request
May 12, 2025
…th 4.0.0-rc5 ### What changes were proposed in this pull request? This PR aims to update `Spark Connect`-generated `Swift` source code with `Apache Spark 4.0.0-rc5`. ### Why are the changes needed? SPARK-51463 added this code with `Apache Spark 4.0.0-rc2`. - #5 There were some changes so far like the following. - apache/spark#50441 The following is the procedure. ``` $ git clone -b v4.0.0-rc5 https://github.com/apache/spark.git $ cd spark/sql/connect/common/src/main/protobuf/ $ protoc --swift_out=. spark/connect/*.proto $ protoc --grpc-swift_out=. spark/connect/*.proto // Remove empty GRPC files $ git grep 'This file contained no services' spark/connect/catalog.grpc.swift:// This file contained no services. spark/connect/commands.grpc.swift:// This file contained no services. spark/connect/common.grpc.swift:// This file contained no services. spark/connect/example_plugins.grpc.swift:// This file contained no services. spark/connect/expressions.grpc.swift:// This file contained no services. spark/connect/ml.grpc.swift:// This file contained no services. spark/connect/ml_common.grpc.swift:// This file contained no services. spark/connect/relations.grpc.swift:// This file contained no services. spark/connect/types.grpc.swift:// This file contained no services. ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #134 from dongjoon-hyun/SPARK-52083. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Like other
Spark Connectclient library, this PR aims to addSpark Connect-generatedSwiftsource code.These will be replaced by Swift Plugin later.
Why are the changes needed?
These files are manually generated from v4.0.0-rc2 tag by the following standard procedures. This will be updated when Apache Spark 4.0.0 is released officially.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.