Skip to content

[SPARK-51521] Add integral/floating/string/date type test and answer files #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Mar 15, 2025

What changes were proposed in this pull request?

This PR aims to add integral/floating/string/date type test and answer files.

Why are the changes needed?

To provide a test coverage for these types. During testings, it turns out decimal and timestamp type has some issues. It will be added.

Does this PR introduce any user-facing change?

No, this is a test-only change.

How was this patch tested?

Pass the CIs and manual tests.

$ swift test --filter SQLTests
...
􀟈  Suite SQLTests started.
􀟈  Test runAll() started.
date.sql
floating.sql
integral.sql
pipesyntax.sql
select.sql
string.sql
􁁛  Test runAll() passed after 0.191 seconds.
􁁛  Suite SQLTests passed after 0.191 seconds.
􁁛  Test run with 1 test passed after 0.191 seconds.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Mar 16, 2025

It's great because you try Swift client. Thank you so much.

Could you review this when you have sometime, @grundprinzip ?

@dongjoon-hyun
Copy link
Member Author

Could you review this when you have some time, @viirya ?

@dongjoon-hyun
Copy link
Member Author

Thank you, @viirya . Merged to main.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-51521 branch March 17, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants