[SPARK-52318] Refactor SparkConnectError to simplify case names
#177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
commented
May 27, 2025
| case InvalidArgument | ||
| case InvalidSessionID | ||
| case InvalidType | ||
| case UnsupportedOperation |
There was a problem hiding this comment.
I sorted these too.
viirya
approved these changes
May 27, 2025
|
Thank you, @viirya ! |
|
Merged to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to refactor
SparkConnectErrorto simplify case names.Why are the changes needed?
We had better simplify case names by removing
Exceptionpostfix before adding more errors likeCatalogNotFoundandSchemaNotFound. InSwift, we use like the following withSparkConnectError.prefix.Does this PR introduce any user-facing change?
Yes, but it's the exception names for 0.x release.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.