Skip to content

[SPARK-52247] Upgrade gRPC Swift Protobuf to 1.3.0 #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented May 21, 2025

What changes were proposed in this pull request?

This PR aims to upgrade gRPC Swift Protobuf to 1.3.

Why are the changes needed?

To bring the latest features and bug fixes.

Does this PR introduce any user-facing change?

No behavior change.

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun
Copy link
Member Author

Thank you, @peter-toth !

BTW, I tested this locally before making the PR, but it seems that CI complains somehow. I'm check the log now.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-52247] Upgrade gRPC Swift Protobuf to 1.3 and gRPC Swift NIO Transport to 1.2 [SPARK-52247] Upgrade gRPC Swift Protobuf to 1.3 May 21, 2025
@dongjoon-hyun
Copy link
Member Author

For the record, I created an empty commit PR and reproduced the same failure. The root cause seems irrelevant to this.

@dongjoon-hyun
Copy link
Member Author

I fixed the root cause in the following and rebased this PR to the main branch to resolve the conflict.

Also, the root cause is filed to the upstream and excluded NIO dependency from this PR.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-52247] Upgrade gRPC Swift Protobuf to 1.3 [SPARK-52247] Upgrade gRPC Swift Protobuf to 1.3.0 May 21, 2025
@dongjoon-hyun
Copy link
Member Author

Merged to main for 0.3.0.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-52247 branch May 21, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants