[SPARK-51493] Refine `merge_spark_pr.py` to use `connect-swift-x.y.z` version #14

dongjoon-hyun · 2025-03-12T19:25:49Z

What changes were proposed in this pull request?

This PR aims to refine merge_spark_pr.py to use connect-swift-x.y.z version pattern.

Why are the changes needed?

To avoid using the version of Apache Spark repository.

Does this PR introduce any user-facing change?

No, this is an dev script.

How was this patch tested?

Manual review.

Was this patch authored or co-authored using generative AI tooling?

No.

… version

dongjoon-hyun · 2025-03-12T19:30:08Z

Could you review this PR when you have some time, @attilapiros ?

attilapiros · 2025-03-12T20:03:12Z

I see this connect-swift-x.y.z is already used in the tickets:

attilapiros · 2025-03-12T20:07:29Z

Let me do a quick test..

dongjoon-hyun · 2025-03-12T20:22:36Z

Thank you, @attilapiros .

This PR aims to filter when it chooses Fixed Version.

dongjoon-hyun · 2025-03-12T20:24:15Z

To test, you can try to merge this PR (SPARK-51493) with this script.

attilapiros

LGTM

Small test:

>>> import re
>>> import jira.client
>>> JIRA_API_BASE = "https://issues.apache.org/jira"
>>> jira_server = {"server": JIRA_API_BASE}
>>> asf_jira = jira.client.JIRA(jira_server)
>>> versions = asf_jira.project_versions("SPARK")
>>> versions
[<JIRA Version: name='0.5.0', id='12326667'>, <JIRA Version: name='0.5.1', id='12326668'>, <JIRA Version: name='0.5.2', id='12326674'>, <JIRA Version: name='0.6.0', id='123
26669'>, <JIRA Version: name='0.6.1', id='12326670'>, <JIRA Version: name='0.6.2', id='12326672'>, <JIRA Version: name='0.7.0', id='12326671'>, <JIRA Version: name='0.7.1',
 id='12326676'>, <JIRA Version: name='0.7.2', id='12326678'>, <JIRA Version: name='0.7.3', id='12326679'>, <JIRA Version: name='0.8.0', id='12326677'>, <JIRA Version: name=
'0.8.1', id='12326681'>, <JIRA Version: name='0.8.2', id='12326685'>, <JIRA Version: name='0.9.0', id='12326682'>, <JIRA Version: name='0.9.1', id='12326684'>, <JIRA Versio
n: name='0.9.2', id='12326687'>, <JIRA Version: name='0.9.3', id='12327384'>, <JIRA Version: name='1.0.0', id='12326683'>, <JIRA Version: name='1.0.1', id='12326744'>, <JIR
A Version: name='1.0.2', id='12327168'>, <JIRA Version: name='1.0.3', id='12327468'>, <JIRA Version: name='1.1.0', id='12326686'>, <JIRA Version: name='1.1.1', id='12327368
'>, <JIRA Version: name='1.1.2', id='12328982'>, <JIRA Version: name='1.2.0', id='12327369'>, <JIRA Version: name='1.2.1', id='12329029'>, <JIRA Version: name='1.2.2', id='
12329321'>, <JIRA Version: name='1.2.3', id='12331971'>, <JIRA Version: name='1.3.0', id='12327642'>, <JIRA Version: name='1.3.1', id='12329486'>, <JIRA Version: name='1.3.
2', id='12329871'>, <JIRA Version: name='1.4.0', id='12329359'>, <JIRA Version: name='1.4.1', id='12332153'>, <JIRA Version: name='1.4.2', id='12332833'>, <JIRA Version: na
me='1.5.0', id='12332078'>, <JIRA Version: name='1.5.1', id='12333108'>, <JIRA Version: name='1.5.2', id='12333643'>, <JIRA Version: name='1.5.3', id='12333969'>, <JIRA Ver
sion: name='1.6.0', id='12333083'>, <JIRA Version: name='1.6.1', id='12334009'>, <JIRA Version: name='1.6.2', id='12334910'>, <JIRA Version: name='1.6.3', id='12336854'>, <
JIRA Version: name='1.6.4', id='12338653'>, <JIRA Version: name='2.0.0', id='12329449'>, <JIRA Version: name='2.0.1', id='12336857'>, <JIRA Version: name='2.0.2', id='12338
301'>, <JIRA Version: name='2.0.3', id='12338608'>, <JIRA Version: name='2.1.0', id='12335644'>, <JIRA Version: name='2.1.1', id='12338779'>, <JIRA Version: name='2.1.2', i
d='12340295'>, <JIRA Version: name='2.1.3', id='12341660'>, <JIRA Version: name='2.1.4', id='12343550'>, <JIRA Version: name='2.2.0', id='12338275'>, <JIRA Version: name='2
.2.1', id='12340470'>, <JIRA Version: name='2.2.2', id='12342171'>, <JIRA Version: name='2.2.3', id='12343560'>, <JIRA Version: name='2.2.4', id='12344921'>, <JIRA Version:
 name='2.3.0', id='12339551'>, <JIRA Version: name='2.3.1', id='12342432'>, <JIRA Version: name='2.3.2', id='12343289'>, <JIRA Version: name='2.3.3', id='12343759'>, <JIRA
Version: name='2.3.4', id='12344844'>, <JIRA Version: name='2.3.5', id='12346043'>, <JIRA Version: name='2.4.0', id='12342385'>, <JIRA Version: name='2.4.1', id='12344117'>
, <JIRA Version: name='2.4.2', id='12344996'>, <JIRA Version: name='2.4.3', id='12345410'>, <JIRA Version: name='2.4.4', id='12345466'>, <JIRA Version: name='2.4.5', id='12
346042'>, <JIRA Version: name='2.4.6', id='12346781'>, <JIRA Version: name='2.4.7', id='12348242'>, <JIRA Version: name='2.4.8', id='12348669'>, <JIRA Version: name='2.4.9'
, id='12350084'>, <JIRA Version: name='3.0.0', id='12339177'>, <JIRA Version: name='3.0.1', id='12347862'>, <JIRA Version: name='3.0.2', id='12348739'>, <JIRA Version: name
='3.0.3', id='12349723'>, <JIRA Version: name='3.1.0', id='12346518'>, <JIRA Version: name='3.1.1', id='12349541'>, <JIRA Version: name='3.1.2', id='12349602'>, <JIRA Versi
on: name='3.2.0', id='12349407'>, <JIRA Version: name='3.1.3', id='12350224'>, <JIRA Version: name='3.0.4', id='12350319'>, <JIRA Version: name='3.2.1', id='12350582'>, <JI
RA Version: name='3.3.0', id='12350369'>, <JIRA Version: name='3.1.4', id='12351224'>, <JIRA Version: name='3.2.2', id='12351232'>, <JIRA Version: name='3.3.1', id='1235171
0'>, <JIRA Version: name='3.2.3', id='12352105'>, <JIRA Version: name='3.2.4', id='12352607'>, <JIRA Version: name='3.3.3', id='12352932'>, <JIRA Version: name='3.4.2', id=
'12353368'>, <JIRA Version: name='3.3.2', id='12352299'>, <JIRA Version: name='3.4.0', id='12351465'>, <JIRA Version: name='3.4.1', id='12352874'>, <JIRA Version: name='3.5
.0', id='12352848'>, <JIRA Version: name='4.0.0', id='12353359'>, <JIRA Version: name='3.5.1', id='12353495'>, <JIRA Version: name='3.3.4', id='12353505'>, <JIRA Version: n
ame='3.5.2', id='12353980'>, <JIRA Version: name='3.4.3', id='12353987'>, <JIRA Version: name='3.4.4', id='12354565'>, <JIRA Version: name='kubernetes-operator-0.1.0', id='
12354567'>, <JIRA Version: name='3.5.3', id='12354954'>, <JIRA Version: name='3.5.4', id='12355093'>, <JIRA Version: name='3.5.5', id='12355518'>, <JIRA Version: name='4.1.
0', id='12355581'>, <JIRA Version: name='3.5.6', id='12355703'>, <JIRA Version: name='connect-swift-0.1.0', id='12355780'>, <JIRA Version: name='4.1', id='12355782'>]
versions_mapped = [
...         x
...         for x in versions
...         if not x.raw["released"]
...         and not x.raw["archived"]
...         and re.match(r"connect-swift-\d+\.\d+\.\d+", x.name)
...  ]
>>> versions_mapped
[<JIRA Version: name='connect-swift-0.1.0', id='12355780'>]

dongjoon-hyun · 2025-03-12T21:16:08Z

Thank you so much, @attilapiros !

dongjoon-hyun · 2025-03-12T21:18:17Z

Merged to main~ (I also used this new script to merge this PR.)

...
Would you like to update an associated JIRA? (y/N): y
Enter a JIRA id [SPARK-51493]:
=== JIRA SPARK-51493 ===
Summary		Refine `merge_spark_pr.py` to use `connect-swift-x.y.z` version
Assignee	None
Status		Open
Url		https://issues.apache.org/jira/browse/SPARK-51493
Affected	['connect-swift-0.1.0']

Check if the JIRA information is as expected (y/N): y
JIRA is unassigned, choose assignee
[0] Dongjoon Hyun (Reporter)
Enter number of user, or userid, to assign to (blank to leave unassigned): 0
Enter comma-separated fix version(s) [connect-swift-0.1.0]:
=== JIRA SPARK-51493 ===
Summary		Refine `merge_spark_pr.py` to use `connect-swift-x.y.z` version
Assignee	Dongjoon Hyun
Status		Resolved
Url		https://issues.apache.org/jira/browse/SPARK-51493
Affected	['connect-swift-0.1.0']
Fixed		['connect-swift-0.1.0']

Successfully resolved SPARK-51493 with fixVersions=['connect-swift-0.1.0']!

[SPARK-51493] Refine merge_spark_pr.py to use connect-swift-x.y.z…

7618bea

… version

dongjoon-hyun changed the title ~~[SPARK-51493] Refine merge_spark_pr.py to use connect-swift-x.y.z…~~ [SPARK-51493] Refine merge_spark_pr.py to use connect-swift-x.y.z version Mar 12, 2025

attilapiros approved these changes Mar 12, 2025

View reviewed changes

dongjoon-hyun closed this in 593c810 Mar 12, 2025

dongjoon-hyun deleted the SPARK-51493 branch March 12, 2025 21:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SPARK-51493] Refine `merge_spark_pr.py` to use `connect-swift-x.y.z` version #14

[SPARK-51493] Refine `merge_spark_pr.py` to use `connect-swift-x.y.z` version #14

Uh oh!

dongjoon-hyun commented Mar 12, 2025 •

edited

Loading

Uh oh!

dongjoon-hyun commented Mar 12, 2025

Uh oh!

attilapiros commented Mar 12, 2025

Uh oh!

attilapiros commented Mar 12, 2025

Uh oh!

dongjoon-hyun commented Mar 12, 2025

Uh oh!

dongjoon-hyun commented Mar 12, 2025

Uh oh!

attilapiros left a comment

Uh oh!

dongjoon-hyun commented Mar 12, 2025

Uh oh!

dongjoon-hyun commented Mar 12, 2025

Uh oh!

Uh oh!

[SPARK-51493] Refine merge_spark_pr.py to use connect-swift-x.y.z version #14

[SPARK-51493] Refine merge_spark_pr.py to use connect-swift-x.y.z version #14

Uh oh!

Conversation

dongjoon-hyun commented Mar 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Was this patch authored or co-authored using generative AI tooling?

Uh oh!

dongjoon-hyun commented Mar 12, 2025

Uh oh!

attilapiros commented Mar 12, 2025

Uh oh!

attilapiros commented Mar 12, 2025

Uh oh!

dongjoon-hyun commented Mar 12, 2025

Uh oh!

dongjoon-hyun commented Mar 12, 2025

Uh oh!

attilapiros left a comment

Choose a reason for hiding this comment

Uh oh!

dongjoon-hyun commented Mar 12, 2025

Uh oh!

dongjoon-hyun commented Mar 12, 2025

Uh oh!

Uh oh!

[SPARK-51493] Refine `merge_spark_pr.py` to use `connect-swift-x.y.z` version #14

[SPARK-51493] Refine `merge_spark_pr.py` to use `connect-swift-x.y.z` version #14

dongjoon-hyun commented Mar 12, 2025 •

edited

Loading