Skip to content

[SPARK-51490] Support iOS, watchOS, and tvOS #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Mar 12, 2025

What changes were proposed in this pull request?

This PR aims to support iOS, watchOS, and tvOS.

Why are the changes needed?

ProcessInfo.processInfo.userName is not allowed in iOS, watchOS, and tvOS according to Platform Compatibility matrix.

Does this PR introduce any user-facing change?

No, the compilation fails on these OSs until now.

How was this patch tested?

Manual review. After this PR, Platform Compatibility should be updated at the next refresh.

https://swiftpackageindex.com/apache/spark-connect-swift

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-51490] Support iOS, watchOS, and tvOS [SPARK-51490] Support iOS, watchOS, and tvOS Mar 12, 2025
@dongjoon-hyun
Copy link
Member Author

Could you review this when you have some time, please, @huaxingao ?

Copy link

@huaxingao huaxingao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dongjoon-hyun
Copy link
Member Author

Thank you so much, @huaxingao ! Merged to main

@dongjoon-hyun dongjoon-hyun deleted the SPARK-51490 branch March 12, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants