[SPARK-51992] Support interrupt(Tag|Operation|All) in SparkSession
#108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
commented
May 3, 2025
| @@ -136,4 +136,25 @@ struct SparkSessionTests { | |||
| } | |||
| await spark.stop() | |||
| } | |||
|
|
|||
| @Test | |||
| func interruptAll() async throws { | |||
There was a problem hiding this comment.
For now, these tests are doing API invocation tests only.
viirya
reviewed
May 3, 2025
| /// Request to interrupt an operation of this session, given its operation ID. | ||
| /// - Returns: Sequence of operation IDs requested to be interrupted. | ||
| @discardableResult | ||
| public func interruptOperation(_ operationId: String) async throws -> [String] { |
There was a problem hiding this comment.
I think this only returns one operation id. Does it need to be a sequence?
There was a problem hiding this comment.
Yes, these Apache Spark 4.0.0 APIs return Seq[String] from Spark side definition.
def interruptAll(): Seq[String]
def interruptTag(tag: String): Seq[String]
def interruptOperation(operationId: String): Seq[String]There was a problem hiding this comment.
It shares the same protobuf reponse where interrupted_ids is repeated string type.
message InterruptResponse {
// Session id in which the interrupt was running.
string session_id = 1;
// Server-side generated idempotency key that the client can use to assert that the server side
// session has not changed.
string server_side_session_id = 3;
// Operation ids of the executions which were interrupted.
repeated string interrupted_ids = 2;
}
viirya
approved these changes
May 3, 2025
|
Thank you, @viirya . |
|
Merged to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to support
interrupt(Tag|Operation|All)API ofSparkSession.Why are the changes needed?
For feature parity.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.