SOLR-17458: Give request handler base errors its own metric #3415
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17458
I feel that the cardinality of
solr_metrics_core_requests_total
was already high enough with the number of handlers + cores as labels and we are bloating it with 3 different types of errorsclient/server/timeouts
. This makes things confusing and I think its justified errors has its own metric name calledsolr_metrics_core_requests_errors_total
.Makes it very easy as well to create its own error aggregation by just querying
solr_metrics_core_requests_errors_total{}
and you get all errors without needs to specify thetype=errors
label.