Skip to content

SOLR-17458: Give request handler base errors its own metric #3415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mlbiscoc
Copy link
Contributor

@mlbiscoc mlbiscoc commented Jul 1, 2025

https://issues.apache.org/jira/browse/SOLR-17458

I feel that the cardinality of solr_metrics_core_requests_total was already high enough with the number of handlers + cores as labels and we are bloating it with 3 different types of errors client/server/timeouts. This makes things confusing and I think its justified errors has its own metric name called solr_metrics_core_requests_errors_total.

Makes it very easy as well to create its own error aggregation by just querying solr_metrics_core_requests_errors_total{} and you get all errors without needs to specify the type=errors label.

solr_metrics_core_requests_errors_total{category="QUERY",collection="demo",core="demo_shard1_replica_n1",handler="/select",internal="false",otel_scope_name="org.apache.solr",replica="replica_n1",shard="shard1",source="client"} 0.0
solr_metrics_core_requests_errors_total{category="QUERY",collection="demo",core="demo_shard1_replica_n1",handler="/select",internal="false",otel_scope_name="org.apache.solr",replica="replica_n1",shard="shard1",source="server"} 0.0
solr_metrics_core_requests_errors_total{category="QUERY",collection="demo",core="demo_shard1_replica_n1",handler="/select",internal="true",otel_scope_name="org.apache.solr",replica="replica_n1",shard="shard1",source="client"} 0.0
solr_metrics_core_requests_errors_total{category="QUERY",collection="demo",core="demo_shard1_replica_n1",handler="/select",internal="true",otel_scope_name="org.apache.solr",replica="replica_n1",shard="shard1",source="server"} 0.0
solr_metrics_core_requests_errors_total{category="QUERY",collection="demo",core="demo_shard1_replica_n1",handler="/select",internal="false",otel_scope_name="org.apache.solr",replica="replica_n1",shard="shard1",type="timeouts"} 0.0
solr_metrics_core_requests_errors_total{category="QUERY",collection="demo",core="demo_shard1_replica_n1",handler="/select",internal="true",otel_scope_name="org.apache.solr",replica="replica_n1",shard="shard1",type="timeouts"} 0.0

@github-actions github-actions bot added the tests label Jul 1, 2025
@dsmiley
Copy link
Contributor

dsmiley commented Jul 3, 2025

Please create PRs with a leading JIRA URL link. The PR template includes this. Personally, this is the only part I retain; I delete the rest.

Copy link
Contributor

@dsmiley dsmiley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mlbiscoc mlbiscoc merged commit 8a92db8 into apache:feature/SOLR-17458 Jul 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants