SOLR-17804: re-create SolrClient if closed. #3411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmiley
changed the title
solr/cross-dc-manager/build.gradle
Outdated
| @@ -32,6 +32,7 @@ dependencies { | |||
| implementation libs.dropwizard.metrics.servlets | |||
| implementation libs.eclipse.jetty.server | |||
| implementation libs.eclipse.jetty.ee10.servlet | |||
| implementation libs.google.guava | |||
There was a problem hiding this comment.
I don't think you need this anymore
| // refresh and check again | ||
| existingClient = solrClientRef.get(); | ||
| if (existingClient.getClusterStateProvider().isClosed()) { | ||
| log.info("- re-creating Solr client because its CSP was closed"); |
There was a problem hiding this comment.
Can we make more normal log messages without -s and not abbreviating things like "CSP"?
There was a problem hiding this comment.
This applies to all added log lines.
sigram
added a commit
to sigram/solr
that referenced
this pull request
Jul 9, 2025
sigram
added a commit
to sigram/solr
that referenced
this pull request
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17804
Use a
Supplier<CloudSolrClient>that automatically re-creates the client if itsClusterStateProvideris closed. Unfortunately SolrClient doesn't implementSolrCloseable.