Skip to content

SOLR-16470: Include IOException in logs when DirectoryFileStream fails #3373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jkmuriithi
Copy link
Contributor

https://issues.apache.org/jira/browse/SOLR-16470

Description

I've been looking at the SolrCloud replication process a lot recently (for this dev list thread), and I noticed that Solr doesn't log the IOException which is thrown when the shard leader fails to write the response. I've linked the Jira ticket from when this API was last modified.

Solution

Made a one-line change to add the IOException to the logs.

Tests

Didn't feel like it was necessary to add new tests. Existing tests all pass.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@jkmuriithi
Copy link
Contributor Author

@mlbiscoc You're probably the best equipped to take a look at this, since you made the original PR.

@mlbiscoc
Copy link
Contributor

Thanks Jude for adding this. Could you also update here as well?

@gerlowskija SOLR-16470 was from a migration v2 migration. Do we still need CHANGES.txt entry for small changes like this and do we still want to reference the old SOLR-16470 v2 Jira for this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants