SmokeTestRelease Added support for multiple JDK (backport 9x) #3342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jan Høydahl <janhoy@apache.org> (cherry picked from commit 98aa723) Signed-off-by: Jan Høydahl <jan.git@cominvent.com>
Signed-off-by: Jan Høydahl <jan.git@cominvent.com>
|
Time for a review @iamsanjay , @HoustonPutman ? |
|
In general, this looks great to me, but I haven't run it locally |
|
Also, as long as we update the Jenkins job and the RC testing email, I don't mind making back-compat breaking changes here... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport attempt for the generalization of smokeTestRelease from main (#2685). Did not merge since there are still important differences between main and 9x that the script must preserve/respect. One such is java versions, another is CLI syntax for invoking Solr examples etc.
(cherry picked from commit 98aa723)