Skip to content

Fix: Enclose variables in double quotes #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025
Merged

Conversation

hrsakai
Copy link
Contributor

@hrsakai hrsakai commented May 12, 2025

Motivation

  • Variables in the script should be enclosed in double quotes.
./download-cpp-client.sh: line 26: [: !=: unary operator expected

Modifications

  • Enclose variables in double quotes in download-cpp-client.sh

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@massakam massakam merged commit d4251d4 into apache:master May 13, 2025
12 checks passed
@shibd shibd modified the milestones: 1.13.0, 1.14.0 May 26, 2025
shibd pushed a commit that referenced this pull request May 26, 2025
* Enclose variables in double quotes

* Do not set SUDO variable if USER variable is not set

(cherry picked from commit d4251d4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants