PHOENIX-7443 Add Spotless to the pre-commit checks

[NihalJain]

No description provided.

[NihalJain]

Follows up #2023
We should merge #2024 before merging this!

[stoty]

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-2119/1/console in case of problems.

[NihalJain]

We get spotless error as expected here. (Since we have not run mvn spotless:apply as done in #2024 yet)

16:37:33  JIRA Plugin: no credentials provided to write a comment.
16:37:35  
16:37:35  
16:37:35  -1 overall
16:37:35  
16:37:35  | Vote |          Subsystem |  Runtime   | Comment
16:37:35  ============================================================================
16:37:35  |   0  |            reexec  |   3m 38s   | Docker mode activated. 
16:37:35  +---------------------------------------------------------------------------
16:37:35  |      |                    |            | Prechecks 
16:37:35  +---------------------------------------------------------------------------
16:37:35  |  +1  |           dupname  |   0m  0s   | No case conflicting files found. 
16:37:35  |  +1  |           @author  |   0m  0s   | The patch does not contain any 
16:37:35  |      |                    |            | @author tags.
16:37:35  +---------------------------------------------------------------------------
16:37:35  |      |                    |            | master Compile Tests 
16:37:35  +---------------------------------------------------------------------------
16:37:35  |   0  |            mvndep  |   0m 58s   | Maven dependency ordering for branch 
16:37:35  |  +0  |    hbaserecompile  |   0m 11s   | HBase recompiled. 
16:37:35  |  -1  |          spotless  |   0m 11s   | branch has 63 errors when running 
16:37:35  |      |                    |            | spotless:check, run spotless:apply to
16:37:35  |      |                    |            | fix.
16:37:35  +---------------------------------------------------------------------------
16:37:35  |      |                    |            | Patch Compile Tests 
16:37:35  +---------------------------------------------------------------------------
16:37:35  |   0  |            mvndep  |   0m  7s   | Maven dependency ordering for patch 
16:37:35  |  +1  |         codespell  |   0m  8s   | No new issues. 
16:37:35  |  +1  |            blanks  |   0m  0s   | The patch has no blanks issues. 
16:37:35  |  +1  |        shellcheck  |   0m  2s   | No new issues. 
16:37:35  |  +1  |         shelldocs  |   0m  2s   | No new issues. 
16:37:35  |  -1  |          spotless  |   0m  6s   | patch has 63 errors when running 
16:37:35  |      |                    |            | spotless:check, run spotless:apply to
16:37:35  |      |                    |            | fix.
16:37:35  +---------------------------------------------------------------------------
16:37:35  |      |                    |            | Other Tests 
16:37:35  +---------------------------------------------------------------------------
16:37:35  |   0  |        asflicense  |   0m  0s   | ASF License check generated no 
16:37:35  |      |                    |            | output?
16:37:35  |      |                    |   5m 44s   |
16:37:35  

Reference: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-2119/1/console

CC: @stoty @mnpoonia @lfrancke

[stoty]

We should make sure to merge the reformat and this one together.

[stoty]

Maybe make PR with both in a commit chain ?

[NihalJain]

Maybe make PR with both in a commit chain ?

Already done at #2120

[NihalJain]

We should make sure to merge the reformat and this one together.

Yes makes sense. But should not be a problem even if we do separately. Advantage being its cleaner and keeps manual and auto generated code change separate. I prefer keeping both separate and merging auto format first and then enforcing in build via this PR.

[stoty]

I agree, separate commits, but we should make sure that nothing gets committed without spotless between the reformat and enabling spotless from CI.

[NihalJain]

e should make sure that nothing gets committed without spotless between the reformat and enabling spotless from CI.

Right we must time to merge both one after another.