system/dd: portability to non-nuttx platforms #3121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
while this is not a goal for this repository, it's convenient for me (hopefully for some others too) to be able to build this for other platforms. an obvious downside is to have a few more ifdefs. tested with: ``` /opt/wasi-sdk-25.0/bin/clang -Wall -Oz -s -o dd.wasm dd_main.c ``` Signed-off-by: YAMAMOTO Takashi <yamamoto@midokura.com>
xiaoxiang781216
approved these changes
Jul 7, 2025
| @@ -31,7 +31,9 @@ | |||
| #include <sys/types.h> | |||
| #include <sys/stat.h> | |||
|
|
|||
| #if defined(__NuttX__) | |||
There was a problem hiding this comment.
Suggested change
| #if defined(__NuttX__) | |
| #ifdef __NuttX__ |
There was a problem hiding this comment.
are you suggesting to change all of them, including the existing one?
cederom
approved these changes
Jul 7, 2025
There was a problem hiding this comment.
Thank you @yamt :-) Good to hear NuttX apps are now ported to other platforms too :-)
Please just update requests by @xiaoxiang781216 before merge :-)
|
Hmm CI complains about code formatting around line 84, could you please take a look @yamt too so we could merge with all successful checks? :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
while this is not a goal for this repository,
it's convenient for me (hopefully for some others too) to be able to build this for other platforms.
an obvious downside is to have a few more ifdefs.
Impact
Testing
tested with: