-
Notifications
You must be signed in to change notification settings - Fork 963
[KYUUBI #7192] Fix filestatus not cached #7191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
flaming-archer
wants to merge
10
commits into
apache:master
Choose a base branch
from
flaming-archer:master_cache
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+524
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cache version 2 cache ut change ut
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7191 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 696 697 +1
Lines 43530 43607 +77
Branches 5883 5898 +15
======================================
- Misses 43530 43607 +77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@pan3793 could u pls take a look at it |
pan3793
reviewed
Sep 11, 2025
...or-hive/src/main/scala/org/apache/kyuubi/spark/connector/hive/read/HiveFileStatusCache.scala
Show resolved
Hide resolved
pan3793
reviewed
Sep 11, 2025
...or-hive/src/main/scala/org/apache/kyuubi/spark/connector/hive/read/HiveFileStatusCache.scala
Outdated
Show resolved
Hide resolved
5b7354e
to
9f2168c
Compare
7950d8b
to
b5aaec0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous filestatus will not be cached, as its source hivetable will be created every time, and the filestatus will also be created, resulting in different client IDs for the cached object's key, leading to cache invalidation.
It can cause two problems:
Why are the changes needed?
Improve perfomance.
How was this patch tested?
UT and spark sql query.
Was this patch authored or co-authored using generative AI tooling?
No.