Skip to content

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Sep 17, 2024

🔍 Description

Spark 4.0.0-preview2 RC1 passed the vote
https://lists.apache.org/thread/4ctj2mlgs4q2yb4hdw2jy4z34p5yw2b1

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Pass GHA.


Checklist 📝

Be nice. Be informative.

@github-actions github-actions bot added kind:infra license, community building, project builds, asf infra related, etc. module:spark kind:build labels Sep 17, 2024
spark: SparkSession,
schemaPattern: String): Seq[String] = {
val database = spark.sharedState.globalTempViewManager.database
val database = spark.conf.get("spark.sql.globalTempDatabase")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see SPARK-48559

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (8e2b1b3) to head (2db1f64).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...rg/apache/kyuubi/engine/spark/SparkSQLEngine.scala 0.00% 1 Missing ⚠️
...e/kyuubi/engine/spark/util/SparkCatalogUtils.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6699   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         684     684           
  Lines       42279   42279           
  Branches     5765    5765           
======================================
  Misses      42279   42279           
Flag Coverage Δ
0.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

// Here we follow the HiveResult.getBinaryFormatter behavior to set it to UTF8 if configuration
// is absent to reserve the legacy behavior for compatibility.
_sparkConf.setIfMissing("spark.sql.binaryOutputStyle", "UTF8")
_sparkConf.setIfMissing("spark.sql.binaryOutputStyle", "UTF-8")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pan3793 pan3793 self-assigned this Sep 21, 2024
@pan3793 pan3793 added this to the v1.9.3 milestone Sep 21, 2024
@pan3793 pan3793 requested a review from cxzl25 September 22, 2024 04:47
@pan3793 pan3793 closed this in 1bfc8c5 Sep 23, 2024
pan3793 added a commit that referenced this pull request Sep 23, 2024
Spark 4.0.0-preview2 RC1 passed the vote
https://lists.apache.org/thread/4ctj2mlgs4q2yb4hdw2jy4z34p5yw2b1

- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

Pass GHA.

---

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes #6699 from pan3793/spark-4.0.0-preview2.

Closes #6699

2db1f64 [Cheng Pan] 4.0.0-preview2
42055bb [Cheng Pan] fix
d29c0ef [Cheng Pan] disable delta test
98d323b [Cheng Pan] fix
2e782c0 [Cheng Pan] log4j-slf4j2-impl
fde4bb6 [Cheng Pan] spark-4.0.0-preview2

Authored-by: Cheng Pan <chengpan@apache.org>
Signed-off-by: Cheng Pan <chengpan@apache.org>
(cherry picked from commit 1bfc8c5)
Signed-off-by: Cheng Pan <chengpan@apache.org>
@pan3793
Copy link
Member Author

pan3793 commented Sep 23, 2024

Thanks, merged to master/1.9

turboFei pushed a commit to turboFei/kyuubi that referenced this pull request Aug 27, 2025
# 🔍 Description

Spark 4.0.0-preview2 RC1 passed the vote
https://lists.apache.org/thread/4ctj2mlgs4q2yb4hdw2jy4z34p5yw2b1

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

Pass GHA.

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#6699 from pan3793/spark-4.0.0-preview2.

Closes apache#6699

2db1f64 [Cheng Pan] 4.0.0-preview2
42055bb [Cheng Pan] fix
d29c0ef [Cheng Pan] disable delta test
98d323b [Cheng Pan] fix
2e782c0 [Cheng Pan] log4j-slf4j2-impl
fde4bb6 [Cheng Pan] spark-4.0.0-preview2

Authored-by: Cheng Pan <chengpan@apache.org>
Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:build kind:infra license, community building, project builds, asf infra related, etc. module:extensions module:spark

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants