-
Notifications
You must be signed in to change notification settings - Fork 965
Fix Trino Status Printer to Prevent Thread Leak #6696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6696 +/- ##
========================================
Coverage 0.00% 0.00%
========================================
Files 680 685 +5
Lines 42007 44690 +2683
Branches 5729 6189 +460
========================================
- Misses 42007 44690 +2683 ☔ View full report in Codecov by Sentry. |
thanks, merged to 1.10.0 |
@lsm1 if this is a bug fix, consider backporting to maintained versions, currently, branch-1.8 and branch-1.9 |
This bug only exists in version 1.10.0, so backporting is not necessary. |
if so, please enrich the PR description to mention the affected version and which commit introduced the bug |
ok, done |
@lsm1 thanks |
# 🔍 Description ## Issue References 🔗 ## Describe Your Solution 🔧 - use `newDaemonSingleThreadScheduledExecutor` avoid `timer` thread leak - reduce same status info out ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6696 from lsm1/branch-fix-trino-printer. Closes apache#6696 01f917c [senmiaoliu] fix style 0d20fd1 [senmiaoliu] fix trino info printer thread leak Authored-by: senmiaoliu <senmiaoliu@trip.com> Signed-off-by: senmiaoliu <senmiaoliu@trip.com>
🔍 Description
Issue References 🔗
Fix thread leak in Trino Status Printer caused by #6387 (affects version 1.10.0)
Describe Your Solution 🔧
newDaemonSingleThreadScheduledExecutor
avoidtimer
thread leakTypes of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.