Skip to content

Conversation

lsm1
Copy link
Contributor

@lsm1 lsm1 commented Sep 14, 2024

🔍 Description

Issue References 🔗

Fix thread leak in Trino Status Printer caused by #6387 (affects version 1.10.0)

Describe Your Solution 🔧

  • use newDaemonSingleThreadScheduledExecutor avoid timer thread leak
  • reduce same status info out

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklist 📝

Be nice. Be informative.

@lsm1 lsm1 requested a review from cxzl25 September 14, 2024 11:27
@lsm1 lsm1 self-assigned this Sep 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (9cf2245) to head (01f917c).
Report is 37 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #6696     +/-   ##
========================================
  Coverage    0.00%   0.00%             
========================================
  Files         680     685      +5     
  Lines       42007   44690   +2683     
  Branches     5729    6189    +460     
========================================
- Misses      42007   44690   +2683     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lsm1 lsm1 closed this in 8056235 Sep 19, 2024
@lsm1
Copy link
Contributor Author

lsm1 commented Sep 19, 2024

thanks, merged to 1.10.0

@pan3793
Copy link
Member

pan3793 commented Sep 19, 2024

@lsm1 if this is a bug fix, consider backporting to maintained versions, currently, branch-1.8 and branch-1.9

@lsm1
Copy link
Contributor Author

lsm1 commented Sep 19, 2024

@lsm1* if this is a bug fix, consider backporting to maintained versions, currently, branch-1.8 and branch-1.9

This bug only exists in version 1.10.0, so backporting is not necessary.

@pan3793
Copy link
Member

pan3793 commented Sep 19, 2024

if so, please enrich the PR description to mention the affected version and which commit introduced the bug

@lsm1
Copy link
Contributor Author

lsm1 commented Sep 19, 2024

if so, please enrich the PR description to mention the affected version and which commit introduced the bug

ok, done

@pan3793
Copy link
Member

pan3793 commented Sep 19, 2024

@lsm1 thanks

turboFei pushed a commit to turboFei/kyuubi that referenced this pull request Aug 27, 2025
# 🔍 Description
## Issue References 🔗

## Describe Your Solution 🔧

- use `newDaemonSingleThreadScheduledExecutor` avoid `timer` thread leak
- reduce same status info out

## Types of changes 🔖

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklist 📝

- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#6696 from lsm1/branch-fix-trino-printer.

Closes apache#6696

01f917c [senmiaoliu] fix style
0d20fd1 [senmiaoliu] fix trino info printer thread leak

Authored-by: senmiaoliu <senmiaoliu@trip.com>
Signed-off-by: senmiaoliu <senmiaoliu@trip.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants