Skip to content

Conversation

turboFei
Copy link
Member

@turboFei turboFei commented Sep 8, 2024

🔍 Description

Issue References 🔗

As title, format the batch command output.

Describe Your Solution 🔧

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklist 📝

Be nice. Be informative.

@wForget
Copy link
Member

wForget commented Sep 12, 2024

Related style error:

Error: ] /home/runner/work/kyuubi/kyuubi/kyuubi-ctl/src/main/scala/org/apache/kyuubi/ctl/cmd/submit/SubmitBatchCommand.scala:20: Unused import

@turboFei
Copy link
Member Author

spotless can not resolve the unused import issue for scala.

Should we involve a script lint-scala to check the scala style fast?

@wForget @pan3793

@wForget
Copy link
Member

wForget commented Sep 12, 2024

Should we involve a script lint-scala to check the scala style fast?

Sounds good to me.

@turboFei turboFei closed this in 8e2b1b3 Sep 14, 2024
turboFei added a commit that referenced this pull request Sep 14, 2024
# 🔍 Description
## Issue References 🔗

As title, format the batch command output.
## Describe Your Solution 🔧

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes #6680 from turboFei/batch_error.

Closes #6680

f9de99b [Wang, Fei] ut
0562d2d [Wang, Fei] unused
d449478 [Wang, Fei] pretty

Authored-by: Wang, Fei <fwang12@ebay.com>
Signed-off-by: Wang, Fei <fwang12@ebay.com>
(cherry picked from commit 8e2b1b3)
Signed-off-by: Wang, Fei <fwang12@ebay.com>
@turboFei turboFei added this to the v1.9.3 milestone Sep 14, 2024
@turboFei turboFei deleted the batch_error branch September 14, 2024 19:55
@turboFei
Copy link
Member Author

thanks, merged to 1.10.0/1.9.3

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (db5ce0c) to head (f9de99b).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...che/kyuubi/ctl/cmd/submit/SubmitBatchCommand.scala 0.00% 2 Missing ⚠️
...che/kyuubi/ctl/cmd/delete/DeleteBatchCommand.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6680   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         684     684           
  Lines       42233   42279   +46     
  Branches     5755    5765   +10     
======================================
- Misses      42233   42279   +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

turboFei added a commit to turboFei/kyuubi that referenced this pull request Aug 27, 2025
# 🔍 Description
## Issue References 🔗

As title, format the batch command output.
## Describe Your Solution 🔧

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#6680 from turboFei/batch_error.

Closes apache#6680

f9de99b [Wang, Fei] ut
0562d2d [Wang, Fei] unused
d449478 [Wang, Fei] pretty

Authored-by: Wang, Fei <fwang12@ebay.com>
Signed-off-by: Wang, Fei <fwang12@ebay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants