Skip to content

Bump Scalafmt to 3.9.x #6674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Bump Scalafmt to 3.9.x #6674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2df5066
bump scalafmt to 3.8
bowenliang123 Sep 5, 2024
438a07d
reformat
bowenliang123 Feb 3, 2025
d9f4f9d
3.9.0
bowenliang123 Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .scalafmt.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version = 3.7.5
version = 3.9.0
runner.dialect=scala212
project.git=true

Expand All @@ -11,7 +11,7 @@ assumeStandardLibraryStripMargin = true
danglingParentheses.preset = false
docstrings.style = Asterisk
docstrings.wrap = no
importSelectors = singleLine
binPack.importSelectors = singleLine
indent.extendSite = 2
literals.hexDigits = Upper
maxColumn = 100
Expand Down
5 changes: 2 additions & 3 deletions kyuubi-util-scala/src/test/scala/org/apache/kyuubi/util/AssertionUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,8 @@ object AssertionUtils {
path: Path,
expectedLines: Traversable[String],
regenScript: String,
splitFirstExpectedLine: Boolean = false)(implicit
prettifier: Prettifier,
pos: Position): Unit = {
splitFirstExpectedLine: Boolean =
false)(implicit prettifier: Prettifier, pos: Position): Unit = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too weird style ...

Copy link
Contributor Author

@bowenliang123 bowenliang123 Feb 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Maybe we would find another way or config to get rid of it in the future. We are modernizing the config name into binPack.importSelectors this time.

val fileSource = Source.fromFile(path.toUri, StandardCharsets.UTF_8.name())
try {
def expectedLinesIter = if (splitFirstExpectedLine) {
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@
<spotless.python.includes></spotless.python.includes>
<spotless.python.black.version>22.3.0</spotless.python.black.version>
<!-- Please also update .scalafmt.conf when you change it here -->
<spotless.scala.scalafmt.version>3.7.5</spotless.scala.scalafmt.version>
<spotless.scala.scalafmt.version>3.9.0</spotless.scala.scalafmt.version>

<distMgmtReleaseId>apache.releases.https</distMgmtReleaseId>
<distMgmtReleaseName>Apache Release Distribution Repository</distMgmtReleaseName>
Expand Down
Loading