JSPWIKI-388 - ParamTag loops forever when parent tag is not ParamHandler #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses an issue in the ParamTag class where, if the parent tag was not an instance of ParamHandler, an infinite loop would occur. This was due to the 'getParent()' method always returning the same object. The fix involves getting the parent of the current tag in the loop, thereby ensuring that we keep moving up the tree until we find a parent that is a ParamHandler or until we run out of parents. This prevents the possibility of an infinite loop and provides a more robust handling of the tag structure.
arturobernalg
force-pushed
the
JSPWIKI-388
branch
from
bf641cc to
e3794f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses an issue in the ParamTag class where, if the parent tag was not an instance of ParamHandler, an infinite loop would occur. This was due to the 'getParent()' method always returning the same object.
The fix involves getting the parent of the current tag in the loop, thereby ensuring that we keep moving up the tree until we find a parent that is a ParamHandler or until we run out of parents. This prevents the possibility of an infinite loop and provides a more robust handling of the tag structure.