Support Update join #761
Open
Support Update join #761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pkg/datasource/sql/exec/at/base_executor.go # pkg/datasource/sql/exec/at/update_executor_test.go
|
luky116
reviewed
Feb 15, 2025
pkg/datasource/sql/conn.go
Outdated
| @@ -244,6 +244,10 @@ func (c *Conn) BeginTx(ctx context.Context, opts driver.TxOptions) (driver.Tx, e | |||
| ) | |||
| } | |||
|
|
|||
| func (c *Conn) GetDbVersion() string { | |||
| return c.res.GetDbVersion() | |||
There was a problem hiding this comment.
我认为是需要支持的，不过或许可以提另外的issues分开去做？
Code-Fight
reviewed
Mar 15, 2025
pkg/datasource/sql/conn.go
Outdated
| @@ -244,6 +244,10 @@ func (c *Conn) BeginTx(ctx context.Context, opts driver.TxOptions) (driver.Tx, e | |||
| ) | |||
| } | |||
|
|
|||
| func (c *Conn) GetDbVersion() string { | |||
| return c.res.GetDbVersion() | |||
|
|
||
| // NewUpdateJoinExecutor get executor | ||
| func NewUpdateJoinExecutor(parserCtx *types.ParseContext, execContent *types.ExecContext, hooks []exec.SQLHook) executor { | ||
| minimumVersion, _ := util.ConvertDbVersion("5.7.5") |
There was a problem hiding this comment.
Avoid using the magic value '5.7.5'.
|
待添加新的issue，读取数据库的元数据，查询版本 |
Merged |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for UPDATE … JOIN statements by introducing a dedicated executor, extending argument traversal, select-field building, and covering the logic with new tests.
- Introduce
updateJoinExecutorto build before-/after-image SELECTs for joined updates - Route
NewUpdateExecutorto use the join executor when a JOIN is present - Extend
baseExecutorwith join-aware argument traversal, select-field logic, and a commonrowsPreparehelper - Add comprehensive unit tests in
update_join_executor_test.go
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/datasource/sql/exec/at/update_join_executor_test.go | New tests for building before-image SQL in UPDATE … JOIN cases |
| pkg/datasource/sql/exec/at/update_join_executor.go | Implementation of updateJoinExecutor and SQL builders |
| pkg/datasource/sql/exec/at/update_executor.go | Dispatches to join executor when a JOIN clause is detected |
| pkg/datasource/sql/exec/at/base_executor.go | Added join argument traversal, select-field builder, and rowsPrepare |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This pr will support update join
Which issue(s) this PR fixes:
Fixes #703
Special notes for your reviewer:
Does this PR introduce a user-facing change?: