Skip to content

chore(vermeer): update go depends module & fix headers #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 27, 2025

Conversation

hankwenyx
Copy link

@hankwenyx hankwenyx commented Apr 27, 2025

Purpose of the PR

Update Vermeer depends module, fix functional test.

Main Changes

Update Vermeer depends module: To fix the compilation problem, upgrade github.com/bytedance/sonic to v1.13.2
Fix config file License.

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)

  • Already covered by existing tests, such as (please modify tests here).

  • Need tests and can be verified as follows.

Does this PR potentially affect the following parts?

  • Nope

  • Dependencies (add/update license info)

  • Modify configurations

  • The public API

Other affects (typed here)

Documentation Status

  • Doc - TODO

  • Doc - Done

  • Doc - No Need

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. documentation Improvements or additions to documentation labels Apr 27, 2025
@imbajin imbajin requested a review from Copilot April 27, 2025 08:09
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Vermeer depends module to address a compilation issue by upgrading the sonic dependency and fixes functional tests along with minor configuration changes.

  • Update functional test commands to invoke the shell explicitly when starting and stopping components.
  • Refresh the CI workflow by updating GitHub Actions versions and adjusting file path filters.

Reviewed Changes

Copilot reviewed 3 out of 11 changed files in this pull request and generated no comments.

File Description
vermeer/test/functional/test_function.go Modified script execution commands to use "sh" for better shell compatibility.
.github/workflows/computer-ci.yml Upgraded several GitHub Actions versions and updated workflow filters.
Files not reviewed (8)
  • vermeer/config/default.ini: Language not supported
  • vermeer/config/master.ini: Language not supported
  • vermeer/config/supervisor.conf: Language not supported
  • vermeer/config/worker.ini: Language not supported
  • vermeer/config/worker01.ini: Language not supported
  • vermeer/config/worker02.ini: Language not supported
  • vermeer/config/worker03.ini: Language not supported
  • vermeer/go.mod: Language not supported
Comments suppressed due to low confidence (4)

vermeer/test/functional/test_function.go:214

  • Explicitly calling 'sh' to execute the script may change the environment context compared to a direct executable call; please ensure this behavior is consistent across all target platforms.
output, err := exec.Command("sh", "vermeer.sh", "stop", "master").Output()

.github/workflows/computer-ci.yml:37

  • Verify that upgrading to actions/setup-java@v4 does not introduce breaking changes and is fully compatible with the current CI requirements.
uses: actions/setup-java@v4

.github/workflows/computer-ci.yml:50

  • Ensure that using actions/setup-python@v5 maintains the expected behavior in the CI environment without regressions.
uses: actions/setup-python@v5

.github/workflows/computer-ci.yml:55

  • Confirm that the changes to actions/cache@v4 do not adversely affect caching behavior in the CI pipeline.
uses: actions/cache@v4

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 27, 2025
@imbajin imbajin changed the title Update Vermeer depends module chore(vermeer): update go depends module & fix headers Apr 27, 2025
@imbajin imbajin merged commit 875f5f4 into apache:master Apr 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants