[GLUTEN-10599][VL] Fix Centos dev docker image build #10600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuan <yuanzhou@apache.org>
Signed-off-by: Yuan <yuanzhou@apache.org>
zhouyuan
force-pushed
the
wip_fix_centos7_docker_build
branch
2 times, most recently
from
58d4ed2 to
d87ac78
Compare
zhouyuan
force-pushed
the
wip_fix_centos7_docker_build
branch
from
d87ac78 to
48c2500
Compare
zhouyuan
changed the title
zhouyuan
commented
Sep 1, 2025
PHILO-HE
reviewed
Sep 2, 2025
16 tasks
PHILO-HE
approved these changes
Sep 2, 2025
zhouyuan
changed the title
Signed-off-by: Yuan <yuanzhou@apache.org>
zhouyuan
force-pushed
the
wip_fix_centos7_docker_build
branch
from
cad7dc0 to
b497a63
Compare
zhouyuan
force-pushed
the
wip_fix_centos7_docker_build
branch
from
f4657c7 to
7db1a13
Compare
PHILO-HE
reviewed
Sep 2, 2025
dev/builddeps-veloxbe.sh
Outdated
|
|
||
| function build_arrow { | ||
| get_velox | ||
| setup_dependencies |
There was a problem hiding this comment.
If we add them here, they will be executed two times in the following complete build at line 306.
get_velox
setup_dependencies
build_velox_backend
Can we move get_velox into setup_dependencies and explicitly add setup_dependencies in dockerfile?
./dev/builddeps-veloxbe.sh --run_setup_script=ON setup_dependencies build_arrow
There was a problem hiding this comment.
let me add a flag to check if we need to run get_velox
Signed-off-by: Yuan <yuanzhou@apache.org>
Signed-off-by: Yuan <yuanzhou@apache.org>
zml1206
pushed a commit
to zml1206/incubator-gluten
that referenced
this pull request
Sep 12, 2025
* [VL] fix centos docker image build --------- Signed-off-by: Yuan <yuanzhou@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This patch fixes the centos7/8 docker image build
fixes; #10602
fixes: #10599
How was this patch tested?
Pass GHA