Calcite schema ddl #957
Merged
Calcite schema ddl #957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // Initialize the type factory | ||
| Properties props = new Properties(); | ||
| props.setProperty(CalciteConnectionProperty.CASE_SENSITIVE.camelName(), "false"); | ||
| CalciteConnectionConfig config = new CalciteConnectionConfigImpl(props); |
Check notice
Code scanning / CodeQL
Unread local variable Note test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 6 months ago
To fix the issue, the unused variable config should be removed. The assignment of props to config on line 78 can be safely deleted, as props is directly used in the subsequent code. This will eliminate the "unread local variable" error without altering the functionality of the code.
Suggested changeset
1
baremaps-calcite/src/test/java/org/apache/baremaps/calcite/data/DataSchemaTest.java
| @@ -77,3 +77,2 @@ | ||
| props.setProperty(CalciteConnectionProperty.CASE_SENSITIVE.camelName(), "false"); | ||
| CalciteConnectionConfig config = new CalciteConnectionConfigImpl(props); | ||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This reverts commit 16f9c82.
bchapuis
force-pushed
the
calcite-schema-ddl
branch
from
14e651e to
dc8a684
Compare
bchapuis
force-pushed
the
calcite-schema-ddl
branch
from
dc8a684 to
eec70db
Compare
bchapuis
force-pushed
the
calcite-schema-ddl
branch
from
e469e6b to
18454ff
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.