Add support for calcite and sql queries #956

bchapuis · 2025-04-05T14:04:17Z

No description provided.

baremaps-calcite/src/main/java/org/apache/baremaps/calcite/DataTableFactory.java

baremaps-calcite/src/main/java/org/apache/baremaps/calcite/baremaps/BaremapsDdlExecutor.java

baremaps-calcite/src/test/java/org/apache/baremaps/calcite/DataTableAdapterFactoryTest.java

baremaps-calcite/src/test/java/org/apache/baremaps/calcite/DataTypeTest.java

baremaps-calcite/src/test/java/org/apache/baremaps/calcite/DataTableAdapterFactoryTest.java

github-advanced-security

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

…ance PostgreSQL type conversion, and update integration tests for schema registration.

…struct type for geometry envelope handling.

…nhance handling of envelope values in data retrieval.

baremaps-calcite/src/main/java/org/apache/baremaps/calcite/BaremapsDdlExecutor.java

baremaps-calcite/src/main/java/org/apache/baremaps/calcite/BaremapsTableFactory.java

baremaps-calcite/src/main/java/org/apache/baremaps/calcite/geopackage/GeoPackageTable.java

+      return null;
+    }
+
+    if (geometry instanceof Point point) {


baremaps-core/src/main/java/org/apache/baremaps/tasks/ImportGeoPackage.java

+                  "SELECT EXISTS (SELECT 1 FROM information_schema.tables WHERE table_name = '" +
+                      sanitizedTableName + "')")) {


baremaps-core/src/main/java/org/apache/baremaps/tasks/ImportGeoParquet.java

+                  "SELECT EXISTS (SELECT 1 FROM information_schema.tables WHERE table_name = '" +
+                      sanitizedTableName + "')")) {


baremaps-core/src/main/java/org/apache/baremaps/tasks/ImportShapefile.java

+                "SELECT EXISTS (SELECT 1 FROM information_schema.tables WHERE table_name = '" +
+                    tableName + "')")) {


baremaps-core/src/test/java/org/apache/baremaps/integration/GeoPackageToPostgresTest.java

+                  "SELECT EXISTS (SELECT 1 FROM information_schema.tables WHERE table_name = '" +
+                      tableName + "')")) {


baremaps-core/src/test/java/org/apache/baremaps/integration/GeoParquetToPostgresTest.java

+                  "SELECT EXISTS (SELECT 1 FROM information_schema.tables WHERE table_name = '" +
+                      tableName + "')")) {


baremaps-calcite/src/test/java/org/apache/baremaps/calcite/csv/CsvTableTest.java

+  @Test
+  void testCsvWithoutHeader() throws Exception {
+    // Create a temporary file without a header
+    File tempFile = File.createTempFile("no_header", ".csv");


To fix the problem, we need to ensure that the temporary file is created with secure permissions that restrict access to the owner only. This can be achieved by using the java.nio.file.Files.createTempFile method, which allows specifying file attributes, including permissions. We will replace the File.createTempFile method with Files.createTempFile and set the appropriate file permissions.

baremaps-calcite/src/test/java/org/apache/baremaps/calcite/csv/CsvTableTest.java

+  @Test
+  void testCsvWithCustomSeparator() throws Exception {
+    // Create a temporary file with a custom separator
+    File tempFile = File.createTempFile("custom_separator", ".csv");


To fix the problem, we need to ensure that the temporary files created in the test have restricted permissions, preventing other local users from reading them. We can achieve this by using the java.nio.file.Files.createTempFile method, which allows us to specify file attributes, including permissions.

We will replace the File.createTempFile calls with Files.createTempFile and ensure the files have permissions set to -rw------- (read and write permissions for the owner only).

sonarqubecloud · 2025-04-11T11:47:01Z

Quality Gate failed

Failed conditions
23 Security Hotspots
6.8% Duplication on New Code (required ≤ 3%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

bchapuis added 12 commits April 5, 2025 14:45

Experiments with calcite

b24d784

Add list

3981793

Format code

a7c82af

Improve GeoPackage store

00b5307

Make data collection closeable

d3383d1

Refactor the sub modules

ae41449

Add header to memory

b9ecee2

Fix issues in header

9196a7f

Merge the calcite and store packages

3e32723

Add the server ddl class and implement materialized views

f5d3112

Some progress

bed98b0

Fix build issues

a535dbc

github-advanced-security bot found potential problems Apr 5, 2025

View reviewed changes

Fix unit test

b1b5db4

github-advanced-security bot found potential problems Apr 5, 2025

View reviewed changes

baremaps-calcite/src/test/java/org/apache/baremaps/calcite/DataTableAdapterFactoryTest.java Fixed Show fixed Hide fixed

baremaps-calcite/src/test/java/org/apache/baremaps/calcite/DataTableAdapterFactoryTest.java Fixed Show fixed Hide fixed

bchapuis added 13 commits April 5, 2025 22:36

New version

d4a8241

Add calcite table

8237230

Add an openstreetmap table

cc4b67a

Add Calcite table for shapefile

8056231

Add calcite rpsl table

8e27d14

Fix unit tests

3ecf5f7

Add flatgeobuf calcite table

9795569

Add Calcite table for geoparquet

0f46587

Add a calcite postgis table and schema

7176093

Delete old implementation of calcite tables

2555b3f

Fix compilation issues in calcite module

93960ee

Format code

c64b95a

Make postgis table modifiable

7105e06

bchapuis force-pushed the calcite-framework branch from 748872f to 7105e06 Compare April 7, 2025 14:49

Add a postgres ddl executor

ff21fa8

bchapuis added 3 commits April 8, 2025 08:03

Import shapefile with calcite

0e7bd88

Test import in postgis

fc56420

Adapt the tasks to calcite

e0c6575

github-advanced-security bot found potential problems Apr 9, 2025

View reviewed changes

bchapuis added 4 commits April 10, 2025 16:21

Refactor GeoPackage and GeoParquet handling; remove debug prints, enh…

06b4276

…ance PostgreSQL type conversion, and update integration tests for schema registration.

Refactor GeoParquet type conversion to use Envelope class instead of …

2636a91

…struct type for geometry envelope handling.

Update GeoParquet type conversion to return Geometry from Envelope; e…

348dbbf

…nhance handling of envelope values in data retrieval.

Fix conversions, enumerator and table

83cdca3

bchapuis force-pushed the calcite-framework branch from b0fce07 to 83cdca3 Compare April 10, 2025 20:54

github-advanced-security bot found potential problems Apr 11, 2025

View reviewed changes

Clean and fix code

c678597

bchapuis force-pushed the calcite-framework branch from b976bb2 to c678597 Compare April 11, 2025 09:31

Add calcite csv schema

18c73fc

github-advanced-security bot found potential problems Apr 11, 2025

View reviewed changes

bchapuis added 2 commits April 11, 2025 13:26

Add a csv schema and revise the overall structure of the package

be9f84f

Fix the test and rat checks

13a4efe

bchapuis merged commit 2b90033 into main Apr 12, 2025
8 of 10 checks passed

@@ -22,2 +22,6 @@
             import java.io.File;
+            import java.nio.file.Path;
+            import java.nio.file.attribute.PosixFilePermission;
+            import java.nio.file.attribute.PosixFilePermissions;
+            import java.util.EnumSet;
             import java.io.IOException;
@@ -133,7 +137,7 @@
                 // Create a temporary file without a header
-                File tempFile = File.createTempFile("no_header", ".csv");
-                tempFile.deleteOnExit();
+                Path tempFilePath = Files.createTempFile("no_header", ".csv");
+                tempFilePath.toFile().deleteOnExit();
                 // Write data without header
-                Files.writeString(tempFile.toPath(),
+                Files.writeString(tempFilePath,
                     "Paris,France,2148000\n" +

@@ -133,4 +133,5 @@
                 // Create a temporary file without a header
-                File tempFile = File.createTempFile("no_header", ".csv");
-                tempFile.deleteOnExit();
+                Path tempFilePath = Files.createTempFile("no_header", ".csv");
+                tempFilePath.toFile().deleteOnExit();
+                Files.setPosixFilePermissions(tempFilePath, EnumSet.of(PosixFilePermission.OWNER_READ, PosixFilePermission.OWNER_WRITE));
@@ -165,4 +166,5 @@
                 // Create a temporary file with a custom separator
-                File tempFile = File.createTempFile("custom_separator", ".csv");
-                tempFile.deleteOnExit();
+                Path tempFilePath = Files.createTempFile("custom_separator", ".csv");
+                tempFilePath.toFile().deleteOnExit();
+                Files.setPosixFilePermissions(tempFilePath, EnumSet.of(PosixFilePermission.OWNER_READ, PosixFilePermission.OWNER_WRITE));

		"SELECT EXISTS (SELECT 1 FROM information_schema.tables WHERE table_name = '" +
		sanitizedTableName + "')")) {

		"SELECT EXISTS (SELECT 1 FROM information_schema.tables WHERE table_name = '" +
		tableName + "')")) {

Add support for calcite and sql queries #956

Add support for calcite and sql queries #956

Uh oh!

Conversation

bchapuis commented Apr 5, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-advanced-security bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Check notice

Check failure

Uh oh!

Check failure

Uh oh!

Uh oh!

Check failure

Uh oh!

Check failure

Uh oh!

Check failure

Uh oh!

Check warning

Copilot Autofix

Check warning

Copilot Autofix

sonarqubecloud bot commented Apr 11, 2025

Quality Gate failed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant