Refactor the PMTiles module #954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bchapuis
commented
Apr 4, 2025
bchapuis
commented
- Extract serialization logic
- Introduce builder patter
- Reduce visibility of internal classes
- Improve resource management
- Split unit tests
- Improve the javadoc
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| */ | ||
| @Override | ||
| public void serialize(List<Entry> entries, OutputStream output) throws IOException { | ||
| var buffer = ByteBuffer.allocate(entries.size() * 48); |
Check notice
Code scanning / CodeQL
Unread local variable Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 7 months ago
To fix the problem, we need to remove the declaration and assignment of the buffer variable, as it is not used anywhere in the method. This change will not affect the existing functionality of the code, as the variable is currently redundant.
Suggested changeset
1
baremaps-pmtiles/src/main/java/org/apache/baremaps/pmtiles/EntrySerializer.java
| @@ -49,3 +49,2 @@ | ||
| public void serialize(List<Entry> entries, OutputStream output) throws IOException { | ||
| var buffer = ByteBuffer.allocate(entries.size() * 48); | ||
| varIntSerializer.writeVarInt(output, entries.size()); |
Copilot is powered by AI and may make mistakes. Always verify output.
baremaps-pmtiles/src/main/java/org/apache/baremaps/pmtiles/EntrySerializer.java
Fixed
Show fixed
Hide fixed
baremaps-pmtiles/src/main/java/org/apache/baremaps/pmtiles/EntrySerializer.java
Fixed
Show fixed
Hide fixed
baremaps-pmtiles/src/main/java/org/apache/baremaps/pmtiles/EntrySerializer.java
Fixed
Show fixed
Hide fixed
baremaps-pmtiles/src/main/java/org/apache/baremaps/pmtiles/EntrySerializer.java
Fixed
Show fixed
Hide fixed
- Extract serialization logic - Introduce builder patter - Reduce visibility of internal classes - Improve resource management - Split unit tests - Improve the javadoc
bchapuis
force-pushed
the
pmtiles-refactoring
branch
from
f45b3a5 to
bf8a892
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.