-
Notifications
You must be signed in to change notification settings - Fork 69
Automatically Add new Label to Newly Created Issues and Close Inactive Issues and PRs After a Certain Period #942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I would appreciate it if you could check the Discussion section of the PR and leave your feedback 😀 Here is the link to the JUnit5 labels. You can also experiment with the behavior of the PR in my repository. |
7451941
to
7a53903
Compare
pull-requests: write | ||
steps: | ||
- uses: actions/stale@28ca1036281a5e5922ead5184a1bbf96e5fc984e # v9 | ||
with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The messages imply that the Baremaps community provided a feedback and will do the actual work. What about encouraging ownership? See my suggestions below for the messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds like a great idea.
In fact, the previous messages were from JUnit5, but the revised messages feel more encouraging. 💪🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 273a92d !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I guess that JUnit does not need to build a community anymore 😆
stale-issue-label: "status: stale" | ||
stale-pr-label: "status: stale" | ||
stale-issue-message: > | ||
If you would like us to be able to process this issue, please provide the requested information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue has been inactive for a while. If you’re still interested, let us know how we can help! Our community is small, and we need contributors like you. If we don’t hear back, we may close it, but you’re always welcome to reopen it. Let’s build this together! 🚀
If you would like us to be able to process this issue, please provide the requested information. | ||
If the information is not provided within the next 2 months, we will be unable to proceed and this issue will be closed. | ||
close-issue-message: > | ||
Closing due to lack of requested feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing this issue due to inactivity. If you’re still interested, let us know! Our community is small, and we need contributors like you. If you provide more details or take the lead on a solution, we’ll be happy to re-open it. Let’s build this together! 🚀
close-issue-message: > | ||
Closing due to lack of requested feedback. | ||
If you would like to proceed with your contribution, please provide the requested information and we will re-open this issue. | ||
stale-pr-message: > |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has been inactive for a while. If you’re still working on it, let us know how we can help! Our community is small, and we need contributors like you. If we don’t hear back, we may close it, but you’re always welcome to reopen it. Let’s build this together! 🚀
If you would like us to be able to process this pull request, please provide the requested information or make the requested changes. | ||
If the information is not provided or the requested changes are not made within the next 2 months, we will be unable to proceed and this pull request will be closed. | ||
close-pr-message: > | ||
Closing due to lack of requested feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing this PR due to inactivity. If you’d like to continue, let us know! Our community is small, and we need contributors like you. Feel free to re-open this PR or submit a new one when you’re ready. Let’s build this together! 🚀
|
Merged! thanks a lot for these gh actions and for the quality of these contributions 🚀 |
Thank you for checking so quickly! If an issue arises, the GitHub Action will automatically apply a |
Sorry, I'm not sure to understand. Can you provide me a pointer for the PR description? |
I think JUnit 5's labels could be a good reference! I also created the To summarize my question: The
Since we've already merged these workflows, there are certain labels that we must create. I'll explain in more detail in the comments below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's anything unclear in my comment, feel free to leave a comment! :)
steps: | ||
- uses: actions/stale@28ca1036281a5e5922ead5184a1bbf96e5fc984e # v9 | ||
with: | ||
only-labels: "status: waiting-for-feedback" # only consider issues and PRs with this label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part checks for issues and PRs that are labeled with status: waiting-for-feedback
.
So, we need to create the status: waiting-for-feedback
label.
issue_number: context.issue.number, | ||
owner: context.repo.owner, | ||
repo: context.repo.repo, | ||
labels: ["status: new"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part of the workflow automatically applies the status: new
label when a new issue is opened.
Therefore, we need to create the status: new
label.
stale-issue-label: "status: stale" | ||
stale-pr-label: "status: stale" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part of the code checks issues and PRs in a stale state using this label.
Therefore, we should create the status: stale
label.
Thank you for the clarification. I created the new, waiting-for-feedback, and stale labels. |
Thank you! However, the label names need to be accurate. Could you please change them to the following names?
|
Ok, got it. I'm discovering this part of gh. |
It seems like you're doing great already! Have a great day! |
Resolves #926
Discussion
Before merging this branch, there are a few things I’d like to discuss.
issue opened
,close
actions are based on thestatus: xxx
label. For example, in GitHub Actions, when an issue is created, it gets labeled withstatus: new.
Then, for issues or PRs labeled withstatus: waiting-for-feedback
checks are performed, and if there’s no further action after a certain period, the issue or PR gets closed.A good example of this is
JUnit5
, which is an open-source project I’m very familiar with.They manage issues and PRs using the
status:
label, and from my experience, it works well.I’d like to bring this approach to Baremaps!
WDYT?