Spark 4.0: Row Lineage support #13310
Draft
+839
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+719
to
+731
| protected InternalRow lineageRow(InternalRow meta) { | ||
| GenericInternalRow row = new GenericInternalRow(2); | ||
| row.setNullAt(0); | ||
| row.setNullAt(1); | ||
|
|
||
| if (meta == null) { | ||
| return row; | ||
| } | ||
|
|
||
| // Ordinals are cached | ||
| if (rowIdOrdinal != null && lastUpdatedOrdinal != null) { | ||
| setIfNotNull(row, 0, meta, rowIdOrdinal); | ||
| setIfNotNull(row, 1, meta, lastUpdatedOrdinal); |
There was a problem hiding this comment.
I'll ideally need to figure out a shared abstraction for both the MoR DeltaWriter impl and CoW so we can share the logic to derive the metadata values instead of duplicating the logic
Comment on lines
+128
to
+134
| if (writeIncludesRowLineage) { | ||
| sparkWriteSchema = sparkWriteSchema.add("_row_id", LongType$.MODULE$); | ||
| sparkWriteSchema = | ||
| sparkWriteSchema.add( | ||
| MetadataColumns.LAST_UPDATED_SEQUENCE_NUMBER.name(), LongType$.MODULE$); | ||
| } | ||
|
|
There was a problem hiding this comment.
Separate helper method updateSparkWriteSchemaWithLineage would make it clearer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements spark 4.0 with Iceberg v3's row lineage feature; this approach uses the new conditional nullification mechanism introduced in 4.0 instead of custom rules that we implemented for 3.5