Core: Use time-travel schema when resolving partition spec in scan #13301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenjian2664
changed the title
findinpath
reviewed
Jun 12, 2025
| if (!useSnapshotSchema() || snapshotId() == null) { | ||
| return specs; | ||
| } | ||
|
|
There was a problem hiding this comment.
can we have a test showcasing the functionality fixed by this contribution?
There was a problem hiding this comment.
I am looking for the proper place to add the test, but I’m not sure where it should go. would appreciate some guidance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slack: https://apache-iceberg.slack.com/archives/C03LG1D563F/p1749201124409489
Fixes : #11162
Fix table scan with filter when doing time-travel