Skip to content

Core: Add manifest writer pool to avoid commit delays #13296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xxubai
Copy link
Contributor

@xxubai xxubai commented Jun 11, 2025

The default iceberg-worker-pool thread pool is shared by many tasks or services. During snapshot writes, if the thread pool is saturated, it may result in significant delays in committing operations.
On the other hand, retries caused by manifest write failures may occupy the iceberg-worker-pool, potentially blocking other tasks that rely on the same thread pool.

@github-actions github-actions bot added the core label Jun 11, 2025
Copy link
Contributor

@singhpk234 singhpk234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for you contribution !

Have some doubts / questions :

  • can you please elaborate more about your workload (a before vs after would be really appreaciated) ?
  • what the worker pool threads are busy doing ?
  • is it in a situation even if you increase the pool size, you will not be able to get it for your actions ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants